Skip to content

Commit 4e9bdec

Browse files
fix(frame-router): move navigation to after attribute changes
move navigation to after attribute changes COMUI-4114
1 parent 6660ccd commit 4e9bdec

File tree

2 files changed

+12
-4
lines changed

2 files changed

+12
-4
lines changed

package-lock.json

Lines changed: 8 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/iframe-coordinator/src/elements/frame-router.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -145,10 +145,6 @@ export default class FrameRouterElement extends HTMLElement {
145145
this._currentPath = newPath;
146146
this._currentClientId = newClientId;
147147

148-
const newLocation = this._frameManager.setFrameLocation(
149-
clientInfo && clientInfo.url,
150-
);
151-
152148
this._frameManager.setFrameSandbox(
153149
(clientInfo && clientInfo.sandbox) || undefined,
154150
);
@@ -159,6 +155,10 @@ export default class FrameRouterElement extends HTMLElement {
159155
(clientInfo && clientInfo.defaultTitle) || undefined,
160156
);
161157

158+
const newLocation = this._frameManager.setFrameLocation(
159+
clientInfo && clientInfo.url,
160+
);
161+
162162
this._dispatchEventWhenConnected(
163163
new CustomEvent("frameTransition", { detail: newLocation }),
164164
);

0 commit comments

Comments
 (0)