Skip to content
This repository was archived by the owner on Oct 4, 2020. It is now read-only.

Is injectReflexive dodgy? #2

Open
paf31 opened this issue Mar 17, 2015 · 2 comments
Open

Is injectReflexive dodgy? #2

paf31 opened this issue Mar 17, 2015 · 2 comments

Comments

@paf31
Copy link
Contributor

paf31 commented Mar 17, 2015

It seems like injectReflexive is going to give us undecidable instance headaches one day...

@garyb
Copy link
Member

garyb commented Mar 17, 2015

Hah, I wondered the same exact thing when I saw it. I don't know, but it seems likely.

@ethul
Copy link
Contributor

ethul commented Oct 18, 2015

This relates to purescript/purescript-free#42, but I thought it might be applicable here.

As another possibility for avoiding overlapping instances, can we just remove the instances defined in the Inject module? So this module would only define the Inject type class with no instances. Then it is on the user to define their own specific instances.

I think the Inject type class is useful to have. And writing your own instances isn't too bad. I just added some prisms for Coproduct, which seems to help:

https://github.com/ethul/purescript-refractor-coproduct

Just a thought!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants