Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL createObjectURL? #1

Open
justinwoo opened this issue Jun 16, 2018 · 5 comments
Open

URL createObjectURL? #1

justinwoo opened this issue Jun 16, 2018 · 5 comments
Labels
status: needs more info This issue needs more info before any action can be done.

Comments

@justinwoo
Copy link

We used to have this in here, but maybe I just haven't found it in the right place.

@gabejohnson
Copy link

Wouldn't it belong in -web-file?

@justinwoo
Copy link
Author

It's under URL and doesn't only work with file objects afaik

@justinwoo justinwoo reopened this Jun 16, 2018
@garyb
Copy link
Member

garyb commented Jun 19, 2018

Gabe is right actually, it's part of the File API: https://w3c.github.io/FileAPI/#dfn-createObjectURL

@gabejohnson
Copy link

I think it makes sense to move URL (and maybe the whole of the History API) from -web-html to -web-dom and change the signatures of Web.DOM.Document.url and Web.DOM.Node.baseURI to return Effect URL instead of Effect String.

Thoughts?

@garyb
Copy link
Member

garyb commented Jun 19, 2018

The type situation with URL is a bit of a mess, but no, I don't think we should do that. Ideally we'd use the "proper" URI type, but that's too opinionated for the -web stuff probably. Plus a bit annoying to use without unsafe construction (...a type-level parser would be nice one day 😉).

The URL that createObjectURL belongs to is just a namespace object, it's not a type that can be constructed. I think adding the two functions it has under Web.File.URL will help avoid confusion with it relating to a URL type that is used elsewhere.

@JordanMartinez JordanMartinez added the status: needs more info This issue needs more info before any action can be done. label Dec 7, 2021
sigma-andex pushed a commit to working-group-purescript-es/purescript-web-dom that referenced this issue Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: needs more info This issue needs more info before any action can be done.
Projects
None yet
Development

No branches or pull requests

4 participants