Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should this library absorb js-timers? #37

Open
thomashoneyman opened this issue Aug 27, 2020 · 1 comment
Open

Should this library absorb js-timers? #37

thomashoneyman opened this issue Aug 27, 2020 · 1 comment
Labels
type: breaking change A change that requires a major version bump.

Comments

@thomashoneyman
Copy link
Contributor

As described in purescript-contrib/purescript-js-timers#18:

When reviewing the timers API I discovered that the relevant MDN documentation is marked obsolete and that functions like setInterval are now part of the WindowOrWorkerGlobalScope mixin, which covers the window object and web workers API.

With that in mind, it seems like the web-html library should perhaps have the additional window functions setTimeout, setInterval, etc. added to them, and this library should be deprecated.

Specifically, these methods are supported, which is more than just the set / clear timeout / interval functions, but it would be a good start to move the relevant js-timers functions here and deprecate that library.

@JordanMartinez JordanMartinez added purs-0.15 A reminder to address this issue or merge this PR before we release PureScript v0.15.0 type: breaking change A change that requires a major version bump. labels Dec 7, 2021
@JordanMartinez
Copy link
Contributor

Links above are broken. But these methods indicate the same thing.

@garyb garyb removed the purs-0.15 A reminder to address this issue or merge this PR before we release PureScript v0.15.0 label Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: breaking change A change that requires a major version bump.
Projects
None yet
Development

No branches or pull requests

3 participants