Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spago search-set command #518

Open
klntsky opened this issue Dec 2, 2019 · 7 comments
Open

spago search-set command #518

klntsky opened this issue Dec 2, 2019 · 7 comments

Comments

@klntsky
Copy link
Collaborator

klntsky commented Dec 2, 2019

We could add a command like this, that could be used to open https://spacchetti.github.io/starsuit/#search:%s in the browser, where %s is a search query.

@klntsky
Copy link
Collaborator Author

klntsky commented Dec 2, 2019

spacchetti/starsuit#1 is a blocker.
We might add multiple tags, which will change the URL pattern.

@f-f
Copy link
Member

f-f commented Dec 15, 2019

@klntsky I agree on having the command, but why open a remote webpage and not the local docs? (This would also avoid the blocker)

@klntsky
Copy link
Collaborator Author

klntsky commented Dec 15, 2019

Because we don't have everything that is in the set locally.

@f-f
Copy link
Member

f-f commented Dec 18, 2019

Right. I was recently considering that downloading the whole package set for every project would actually be not that bad, because:

  • with the global cache you would just download it once
  • because of the above, starting projects offline would be totally feasible - it currently isn't because you'd have to download stuff if you wanted to use a library that is in the set but not cached, I got bitten by this recently

So the idea would be:

  • have spago install actually download all libraries in the set to the cache, and only copy to .spago the ones used in the project
  • unless people do spago search-set, which would copy all of them and generate docs locally

@f-f
Copy link
Member

f-f commented Dec 18, 2019

Of course we could do both, e.g. default local and remote with spago search-set --remote

@klntsky
Copy link
Collaborator Author

klntsky commented Dec 18, 2019

have spago install actually download all libraries in the set to the cache, and only copy to .spago the ones used in the project
unless people do spago search-set, which would copy all of them and generate docs locally

Downloading the whole set is not required for spago install, so it's better to do it before search-set.

Also, purescript/package-sets/issues/490 is still unresolved.

@f-f
Copy link
Member

f-f commented Dec 18, 2019

Also, purescript/package-sets/issues/490 is still unresolved

Right, it's not yet implemented in package-sets CI, but it is almost solved in practice: basically we started having @spacchettibotti automatically upgrade dependencies in there (see e.g. purescript/package-sets#547), and part of what it does is to run spago verify-set (which includes trying to ACME-build the whole thing as per the latest release) after trying to upgrade packages. Code here:
https://github.com/spacchetti/spago/blob/b99fe06eaded5d73b63c188f43fea7892e6dced9/app/Curator.hs#L449-L454

So this check is not running on 100% of the PRs, but it is run every time there's a new release out of some package in the set, which is pretty often

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants