Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: make link between setup-env and install-env clear #5

Open
getlarge opened this issue Sep 14, 2024 · 1 comment
Open

refactor: make link between setup-env and install-env clear #5

getlarge opened this issue Sep 14, 2024 · 1 comment
Labels
➕ enhancement New feature or request 🆘 help wanted Assistance is required

Comments

@getlarge
Copy link
Collaborator

getlarge commented Sep 14, 2024

One thing could make the whole flow you worked on more transparent: create an explicit link (dependency) between the setup-env and install-env targets.

When I look at the task pipeline, I can see clearly, e2e target will trigger setup-env:
Screenshot 2024-09-14 at 17 19 06

But what will setup-env trigger? Now I know (since I navigated through the codebase) that it will call the install-env executor declared by the Nx plugin createNodes API.
This is all very implicit...
As soon as you search for install-e2e, TADA, things become clearer because targets have self-describing names:

Screenshot 2024-09-14 at 17 21 04

Could we imagine a refactoring of the runSetupEnvironmentExecutor that depends on install-env running first?
Do you think this flow should remain opaque?

@BioPhoton
Copy link
Contributor

I really like the feedback!! I was already tempted to refactor it as I see it as a big downside that is is all implicit.
I did not go on with the refactor as we had no tests so far.

Now that at least unit tests are in we can more confidently change the codebase.

@BioPhoton BioPhoton added ➕ enhancement New feature or request 🆘 help wanted Assistance is required labels Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
➕ enhancement New feature or request 🆘 help wanted Assistance is required
Projects
None yet
Development

No branches or pull requests

2 participants