Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a teardown target #51

Open
5 of 8 tasks
BioPhoton opened this issue Oct 12, 2024 · 0 comments · Fixed by #52
Open
5 of 8 tasks

Introduce a teardown target #51

BioPhoton opened this issue Oct 12, 2024 · 0 comments · Fixed by #52
Assignees
Labels
📚 code documentation Code related documentation 🤓 Dx Developer Experience ➕ enhancement New feature or request

Comments

@BioPhoton
Copy link
Contributor

BioPhoton commented Oct 12, 2024

User story

As a developer that debugs e2e tests I want to disable the teardown logic to be able to inspect the environment.
After i am done, I want to have a convenient way to clean up the left over files as well as running processes.

At the moment we can do that over --keepServerRunning argument in the env-bootstrap target and the we use the kill-process target to stop the server. What is missing is a cleanup of the test folder and files.

This introduces a bad DX for developers as:

  • changes in the configuration need to happen in multiple places
  • teardown and cleanup is handled centralised and should be per step
  • rebooting of a environment is not possible (starting task's into a existing setup without conflicts)
  • hard cleaup before start is not possible

Acceptance criteria

  • add new environment target nxv-env-teardown and add it to all environments
    • reverts changes to all files
    • deletes all created files and folders
    • if running stops related server
    • works for temporary folders as well as static test folders in git history
  • teardown is executed by default if a .verdaccio-registry.json is present
  • feature is documented
  • feature is tested

Implementation details

No response

@BioPhoton BioPhoton added 📚 code documentation Code related documentation ➕ enhancement New feature or request 🤓 Dx Developer Experience labels Oct 12, 2024
@BioPhoton BioPhoton self-assigned this Oct 12, 2024
@BioPhoton BioPhoton reopened this Oct 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📚 code documentation Code related documentation 🤓 Dx Developer Experience ➕ enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant