Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve teardown logic #52

Merged
merged 21 commits into from
Oct 13, 2024
Merged

feat: improve teardown logic #52

merged 21 commits into from
Oct 13, 2024

Conversation

BioPhoton
Copy link
Contributor

@BioPhoton BioPhoton commented Oct 13, 2024 •
edited
Loading

This PR adds logic to improve cleanup of targets:

  • add env-teardown target - stop verdaccio if running, delete dynamic env, reset static env
  • add nxv-e2e target - wraps e2e with teardown logic
  • cleanup of env-setup target - delete registry storage, .npmrc
  • adjust @code-pushup report
  • fix task time renamings

closes #51

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 13, 2024 •
edited
Loading

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared target commit 96bbef4 with source commit 41bf879.

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🟡 57 🟡 67 ↑ +9.6
👍 2 audits improved, 👎 1 audit regressed, 2 audits changed without impacting score

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Nx Performance Checks [Task Time] models-e2e:e2e 🟨 10.38 s 🟨 10.77 s ↑ +4 %
Nx Performance Checks [Graph Time] task graph 🟩 3.95 ms 🟩 3.47 ms ↓ −12 %
Nx Performance Checks [Cache Size] models-e2e:nxv-env-setup 🟩 3.71 kB 🟩 1.4 kB ↓ −62 %
Nx Performance Checks [Task Time] cli-e2e-original:original-e2e 🟥 155.22 s 🟥 153.28 s ↓ −1 %
Nx Performance Checks [Graph Time] project graph 🟥 2796.77 ms 🟥 2984.28 ms ↑ +7 %

@BioPhoton BioPhoton merged commit cba2e67 into main Oct 13, 2024
6 checks passed
@BioPhoton BioPhoton deleted the add-env-teardown branch October 13, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Introduce a teardown target
1 participant
@BioPhoton