Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 [BUG] - [BUMP SDK IN DAPP] - Fix the the modal close behaviour on click outside modal #1561

Closed
HarshRajat opened this issue May 21, 2024 — with Slack · 1 comment · Fixed by #1611
Closed

🐛 [BUG] - [BUMP SDK IN DAPP] - Fix the the modal close behaviour on click outside modal #1561

HarshRajat opened this issue May 21, 2024 — with Slack · 1 comment · Fixed by #1611
Assignees
@abhishek-01k
Labels
bug Something isn't working

Comments

@HarshRajat Slack
Copy link
Contributor

When we start creating the group, the modal goes away on any render changes or even when night mode is toggled. Having a state that persists instead of modal wrapper that is non-persistent should solve the issue.
@HarshRajat HarshRajat added the bug Something isn't working label May 21, 2024 — with Slack
@rohitmalhotra1420 rohitmalhotra1420 changed the title Create group modal doesn't persist [BUG] - Create group modal doesn't persist May 22, 2024
@abhishek-01k
Copy link
Collaborator

This is an sdk issue so have created a ticket on the sdk side -> push-protocol/push-sdk#1338

So, we can close this issue @rohitmalhotra1420

@rohitmalhotra1420 rohitmalhotra1420 changed the title [BUG] - Create group modal doesn't persist 🐛 [BUG] - [BUMP SDK IN DAPP] - Fix the the modal close behaviour on click outside modal Jun 5, 2024
@abhishek-01k abhishek-01k mentioned this issue Jun 7, 2024
Merged
13 tasks
@abhishek-01k abhishek-01k linked a pull request Jun 7, 2024 that will close this issue
[BUMP SDK IN DAPP] - Fix the the modal close behaviour on click outside modal #1611
Merged
13 tasks
@rohitmalhotra1420 rohitmalhotra1420 mentioned this issue Jun 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abhishek-01k abhishek-01k

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@HarshRajat @abhishek-01k