Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [BUG] - <Include GovernorVotesCompUpgradeable to ensure getVotes() support> #19

Closed
zaryab2000 opened this issue Feb 26, 2024 · 0 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request priority 1

Comments

@zaryab2000
Copy link
Collaborator

zaryab2000 commented Feb 26, 2024

Expected Behaviour

OZ Governor contracts follow getVotes instead of getCurrentVotes(). While PUSH Token contract supports getCurrentVotes()

We need to provide support for getCurrentVotes by using the GovernorVotesCompUpgradeable contract.

Note: This will eventually mean lowering the OZ governor contract version from 5 to 4.9.5

Current Behaviour

no support for outdated getCurrentVotes() function.

Contract Name

Bravo Logic

Chains

Mainnet(Ethereum), Testnet(Sepolia)

@zaryab2000 zaryab2000 added the bug Something isn't working label Feb 26, 2024
@zaryab2000 zaryab2000 self-assigned this Feb 26, 2024
@zaryab2000 zaryab2000 added enhancement New feature or request priority 1 labels Feb 26, 2024
@zaryab2000 zaryab2000 added this to the On-Chain Governance v1.0.0 milestone Feb 26, 2024
@zaryab2000 zaryab2000 assigned Zartaj0 and unassigned zaryab2000 Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request priority 1
Projects
None yet
Development

No branches or pull requests

2 participants