Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Remove the user property from the ConnectedUser class #71

Closed
madhur-push opened this issue Dec 6, 2023 · 0 comments · Fixed by #75
Closed

[BUG] Remove the user property from the ConnectedUser class #71

madhur-push opened this issue Dec 6, 2023 · 0 comments · Fixed by #75
Assignees
@gbogboadePush
Labels
priority-3

Comments

@madhur-push
Copy link
Contributor

We are still creating an unnecessary property for user inside of ConnectedUser even after extending it, here is what is required:

  • We remove the final User user ppt from the ConnectedUser class
  • The current constructor we have has to be renamed as ConnectedUser.fromUser({required User user}), idea being we'll create a ConnectedUser object from passed user object
  • We update the constructor we have rn to take ppts in the User constructor along with the privateKey
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gbogboadePush gbogboadePush

Labels
priority-3
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove the user property from the ConnectedUser class push-protocol/push-restapi-dart
3 participants
@mohammeds1992 @madhur-push @gbogboadePush