Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

😈 [Improvement Proposal] - add key in chatviewlist #1033

Closed
KlausMikhaelson opened this issue Jan 17, 2024 · 2 comments
Closed

😈 [Improvement Proposal] - add key in chatviewlist #1033

KlausMikhaelson opened this issue Jan 17, 2024 · 2 comments
Assignees

Comments

@KlausMikhaelson
Copy link
Contributor

Proposal name

adopting good practices by removing warnings and errors

Describe the Proposal

add key in chatviewlist

Use Case

each list should have a unique key

Current Limitations

it is giving a warning on dapps that has it integrated
Screenshot 2024-01-16 at 8 13 37 PM

@KlausMikhaelson KlausMikhaelson added good first issue Good for newcomers and removed good first issue Good for newcomers labels Jan 17, 2024
@KlausMikhaelson KlausMikhaelson self-assigned this Jan 17, 2024
@bagariaraj23
Copy link

In the chatview list you have passed the chatID already, Is that acting as the key ? or do we need to add any key value to it ? I mean I'm unable to completely understand the requirement

@KlausMikhaelson
Copy link
Contributor Author

Hey @bagariaraj23 , we realized later on that it was a dapp error and not something from sdk so this issue is not relevant now, would highly recommend to check some other issues that are now open in push dapp
Thank you!

@KlausMikhaelson KlausMikhaelson closed this as not planned Won't fix, can't repro, duplicate, stale Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants