Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 [BUG] - NFT Chat Issue With High Level Class Functions #937

Closed
Aman035 opened this issue Dec 19, 2023 · 1 comment · Fixed by #938
Closed

🐛 [BUG] - NFT Chat Issue With High Level Class Functions #937

Aman035 opened this issue Dec 19, 2023 · 1 comment · Fixed by #938
Assignees
@Aman035
Labels
bug Something isn't working
Milestone
Push Optimisation...

Comments

@Aman035
Copy link
Member

Aman035 commented Dec 19, 2023

Expected Behaviour

NFT chat seems to have issues with creating grp. Group Creator should be the NFT Account.

Current Behaviour

Group creator is being set to the owner address of the NFT.
Also currently class based implementation has no way for resetting the NFT Profile

Reproduction steps

Try using createGroup with NFT Profile

Screenshots

![DESCRIPTION](LINK.png)

Relevant Logs

No response

Dapp Env

Prod (app.push.org), Staging (staging.push.org), Dev (dev.push.org)

Browsers

No response
@Aman035 Aman035 added the bug Something isn't working label Dec 19, 2023
@Aman035 Aman035 self-assigned this Dec 19, 2023
@Aman035 Aman035 added this to the Push SDK V1.6 milestone Dec 19, 2023
@Aman035 Aman035 linked a pull request Dec 19, 2023 that will close this issue
fix: NFTChat High Level Fixes #938
Merged
5 tasks
@Aman035 Aman035 mentioned this issue Dec 20, 2023
Merged
5 tasks
@HarshRajat
Copy link
Contributor

@mohammeds1992 can you review this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Aman035 Aman035

Labels
bug Something isn't working
Projects
None yet
Milestone
Push Optimisations V1.6
Development

Successfully merging a pull request may close this issue.

fix: NFTChat High Level Fixes push-protocol/push-sdk
2 participants
@HarshRajat @Aman035