Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

😈 [Improvement Proposal] - Remove @pushprotocol/socket dependency in restapi package #945

Closed
Aman035 opened this issue Dec 20, 2023 · 1 comment · Fixed by #951
Closed

😈 [Improvement Proposal] - Remove @pushprotocol/socket dependency in restapi package #945

Aman035 opened this issue Dec 20, 2023 · 1 comment · Fixed by #951
Assignees
@Aman035
Labels
enhancement New feature or request
Milestone
Push Optimisation...

Comments

@Aman035
Copy link
Member

Aman035 commented Dec 20, 2023 •
edited
Loading

Proposal name

Remove @pushprotocol/socket depe

Describe the Proposal

Since @pushprotocol/socket is no longer used and will be deprecated in further releases, its better to stop using it as a dependency in restapi package
@Aman035
Copy link
Member Author

Aman035 commented Dec 20, 2023

Also since ethersV5 is a dependency for socket package, this even helps to decouple when we move to #861

@Aman035 Aman035 self-assigned this Dec 20, 2023
@Aman035 Aman035 added this to the Push SDK V1.6 milestone Dec 20, 2023
@Aman035 Aman035 mentioned this issue Dec 21, 2023
Merged
5 tasks
@Aman035 Aman035 added the enhancement New feature or request label Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Aman035 Aman035

Labels
enhancement New feature or request
Projects
None yet
Milestone
Push Optimisations V1.6
Development

Successfully merging a pull request may close this issue.

fix: remove @pushprotocol/socket dependency from restapi push-protocol/push-sdk
1 participant
@Aman035