Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

😈 [Improvement Proposal] - String case for Participant status in a Grp #953

Closed
Aman035 opened this issue Dec 21, 2023 · 0 comments · Fixed by #954
Closed

😈 [Improvement Proposal] - String case for Participant status in a Grp #953

Aman035 opened this issue Dec 21, 2023 · 0 comments · Fixed by #954
Assignees
@Aman035
Labels
enhancement New feature or request
Milestone
Push Optimisation...

Comments

@Aman035
Copy link
Member

Aman035 commented Dec 21, 2023 •
edited
Loading

Proposal name

String case for Participant status in a Grp

Describe the Proposal

PushAPI class currently returns the participant status as "ADMIN" or "admin"
Using a standardized case will help to maintain uniformity.

group.participants.list returns the role in lowercase while group.participants.status returns the role in uppercase

Use Case

NA

Current Limitations

NA
@Aman035 Aman035 self-assigned this Dec 21, 2023
@Aman035 Aman035 added the enhancement New feature or request label Dec 21, 2023
@Aman035 Aman035 added this to the Push SDK V1.6 milestone Dec 21, 2023
@Aman035 Aman035 linked a pull request Dec 21, 2023 that will close this issue
fix case for member Status string #954
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Aman035 Aman035

Labels
enhancement New feature or request
Projects
None yet
Milestone
Push Optimisations V1.6
Development

Successfully merging a pull request may close this issue.

fix case for member Status string push-protocol/push-sdk
1 participant
@Aman035