😈 [Feature Enhancement] - <Additional changes in v2.5 contracts>

[zaryab2000]

Feature name

Core Contract folder includes v2.5 and v2_Temp contracts

Describe the Enhancement

Based on the recent review of all changes of Temp and v2.5 contract files, the following changes are suggested:

1. sendFunds() function shouldn't be part of PushCoreV2_Temp since the temp contract's main purpose is to simply provide pausability feature for staking-related functions.
2. Some of the changes of PushCoreV2.5 contracts is not in sync with PushCoreV2_Temp. (Although the contract will eventually be upgraded, it migtht be better to keep them in sync for the sake readability and future reviews. Additionally, not all functions will be paused during Temp, so users still need the updated functions in Temp too)

• setMinPoolContribution() function's custom error is different between the two contracts

• setFeeAmount function has a missing statement in core_temp

• destroyTimeBoundChannel function's if statement is not in sync

POC if available

No response

Contract Name

Core Contract