Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

😈 [Feature Enhancement] - <Include CallerNotGovernance as a Global error in the Errors library> #286

Closed
zaryab2000 opened this issue Feb 2, 2024 · 0 comments · Fixed by #287
Assignees
Labels
bug Something isn't working priority-2 Medium priority

Comments

@zaryab2000
Copy link
Collaborator

Feature name

As of now, the errors file only include CallerNotAdmin custom error that is triggered in onlyAdmin functions

Describe the Enhancement

Moving forward, we will admin as well as governance and there must be a CallerNotGovernance error as well.

This issue requires the following:

  • Create a new CallerNotGovernance error type in Errors.sol library
  • Include Errors.CallerNotGovernance() for onlyGovernance() accessible function - in both Core and Comm contracts
  • Update all test cases accordingly to reflect the same

POC if available

No response

Contract Name

Core Contract, Comm Contract

@zaryab2000 zaryab2000 added bug Something isn't working priority-1 Indicates highest priority labels Feb 2, 2024
@zaryab2000 zaryab2000 added this to the Push Governance v1.0.0 milestone Feb 2, 2024
@zaryab2000 zaryab2000 added priority-2 Medium priority and removed priority-1 Indicates highest priority labels Feb 2, 2024
@Zartaj0 Zartaj0 linked a pull request Feb 2, 2024 that will close this issue
@zaryab2000 zaryab2000 assigned Zartaj0 and unassigned Zartaj0 Feb 2, 2024
@Zartaj0 Zartaj0 self-assigned this Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority-2 Medium priority
Projects
None yet
2 participants