Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [BUG] - AddDelegate and RemoveDelegate emits event even if delegate is already added or not present respectively #438

Closed
0xNilesh opened this issue Nov 21, 2024 · 0 comments
Assignees
Labels
bug Something isn't working priority-2 Medium priority

Comments

@0xNilesh
Copy link
Member

Expected Behaviour

AddDelegate should only emit the event if delegate was not added earlier
and similarly removeDelegate should only emit the event if delegate was added earlier

Current Behaviour

Both fn just emits the event

Reproduction steps

1. Add a delegate
2. Call addDelegate again

Screenshots

![DESCRIPTION](LINK.png)

POC if available

No response

Contract Name

Comm Contract

Chains

No response

@0xNilesh 0xNilesh added the bug Something isn't working label Nov 21, 2024
@zaryab2000 zaryab2000 added the priority-2 Medium priority label Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority-2 Medium priority
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

3 participants