Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tls 1.2 support #151

Open
JanOudkerk opened this issue Apr 18, 2024 · 3 comments
Open

Tls 1.2 support #151

JanOudkerk opened this issue Apr 18, 2024 · 3 comments
Labels

Comments

@JanOudkerk
Copy link

Our software calls the PusherClient dll from unmanaged code (C++). As a result it uses TLS 1.0 as its security protocol.
For some unknown reason this is the default when a .net component is called from unmanaged code.

We resolved this by modifying WebSocket's constructor in Connection.cs to set it to SslProtocols.Tls12.

This is a quick fix that works for us.
Probably better to put this setting in the PusherOptions object?

image

@JanOudkerk
Copy link
Author

We implemented these changes in fork https://github.com/JanOudkerk/pusher-websocket-dotnet.git
(I wasn't succesful in sending a pull request to this repo)

Copy link

stale bot commented Feb 1, 2025

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you'd like this issue to stay open please leave a comment indicating how this issue is affecting you. Thank you.

@stale stale bot added the wontfix label Feb 1, 2025
@JanOudkerk
Copy link
Author

We created a pull request for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant