Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calibration doesn't abort properly when the device lost tracking #99

Open
BrianMwit opened this issue Jan 2, 2023 · 0 comments · May be fixed by #100
Open

Calibration doesn't abort properly when the device lost tracking #99

BrianMwit opened this issue Jan 2, 2023 · 0 comments · May be fixed by #100
Labels
bug Something isn't working

Comments

@BrianMwit
Copy link

BrianMwit commented Jan 2, 2023 •
edited
Loading

During a calibration process, if one of the devices lost its tracking (ie, vive tracker can't see lighthouse), the calibration process will automatically stop.
However, when starting a new calibration, it continues where it left off, using bad sample from the aborted run.

In addition, if the aborted run was running in, say VERY_SLOW 500 samples mode,
then the calibration that is rerun in FAST 100 samples mode,
the existing collected samples could already be more than 100, causing the process to never terminate, requiring app restart.
@BrianMwit BrianMwit added the bug Something isn't working label Jan 2, 2023
@BrianMwit BrianMwit linked a pull request Jan 2, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Calibration: Clear collected samples when aborted BrianMwit/OpenVR-SpaceCalibrator
1 participant
@BrianMwit