Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to grab and offset space to do fine adjust. #35

Open
sidequestlegend opened this issue Nov 12, 2020 · 4 comments
Open

Ability to grab and offset space to do fine adjust. #35

sidequestlegend opened this issue Nov 12, 2020 · 4 comments
Labels
enhancement New feature or request

Comments

@sidequestlegend
Copy link


name: Ability to grab and offset space to do fine adjust.
about: I suggest this a potential solution to #15 without the need to use an extra tracker. I'm a decent coder and I would love to do a PR but i cant write cpp. I would love to know your thoughts.

So the idea would be a 2 handed grab that would let you rotate and translate the space to fine adjust the calibration.
title: 'Ability to grab and offset space to do fine adjust. '
labels: enhancement
assignees: ''


@sidequestlegend sidequestlegend added the enhancement New feature or request label Nov 12, 2020
@sidequestlegend
Copy link
Author

sidequestlegend commented Nov 13, 2020

Just another comment on this as well as some more background. I'm using Oculus Quest with Vive trackers so it suffers from bad drift as the space re-aligns. I feel this solution could possibly make it much quicker to calibrate rather than having to wait the 10-15 seconds for it to capture the samples during calibration. I think on the edit calibration screen this could fit quite nicely, that while on that screen you could use the grips to grab the openvr tracking space and offset it ( kinda like you were putting on a pair of trousers ).

Looking at the code its actually a lot more straightforward than some of the c++ im used to seeing so i might attempt a PR here. Please let me know what is the best way to run the dev stack and if you would be open to such a PR.

Here is my changes incase you are interested, this is untested at time of writing - #37

@pushrax
Copy link
Owner

pushrax commented Nov 13, 2020

We've discussed this feature on Discord before, I think it would be a good inclusion.

You should be able to open the .sln file in Visual Studio 2015 or 2017 and just build without any dependency setup. The project is currently set up for v140 build tools (VS 2015), but 2017 should be able to automatically migrate it to v141 (VS 2017). I should migrate it all over to 2019, but just haven't yet.

Since you don't need to make changes to the driver, for running your own build you can open SteamVR, close OpenVR Space Calibrator that's automatically launched, and then launch in Visual Studio.

@sidequestlegend
Copy link
Author

Awesome! Ive got a start in #37 I hope to finish it off by tomorrow

@sidequestlegend
Copy link
Author

Hey! So an update on this. I now have the ability to grab and offset the target tracking space using the reference controller with the grip pressed ( with some caveats ) - this is already pretty useful though and I am already using it with my setup.

What I can't seem to figure out is the correct rotation calculation for it to make sense to grab/rotate the space. If you had any insight on this, it would be much appreciated, I have left my attempts commented out in case its useful, but I suspect pretty far from grasping the math involved. I would love to have a chat about this in terms of the afore mentioned caveats and the overall implementation of what I'm trying to do.

#37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants