Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply Decidim GEO bugfix #432

Closed
larsUE opened this issue May 21, 2024 · 7 comments
Closed

Apply Decidim GEO bugfix #432

larsUE opened this issue May 21, 2024 · 7 comments
Assignees
Labels
bug Something isn't working

Comments

@larsUE
Copy link
Collaborator

larsUE commented May 21, 2024

Currently, dedicim Geo displays maps everywhere, even then when no geolocated data is present.

This currently blocks our deployment

As soon as octree has the bugfix, please install it on our side.

@froger: Have you got any updates on this?

@larsUE larsUE added bug Something isn't working blocked blocked until further notice labels May 21, 2024
@larsUE larsUE removed the blocked blocked until further notice label May 23, 2024
@larsUE
Copy link
Collaborator Author

larsUE commented May 23, 2024

Update 0.2.2. has the bugfix! Thanks a lot.

@Robin481
Copy link
Member

@larsUE
There seems to be an issue with v0.2.2.
I am following the installation guide, after upgrading the gem one should execute bundle exec rails decidim_geo:install:migrations.
This doesn't work at the moment, it looks like some required files are not there.

I've spoken to @Kagemaru and he told me that we don't have a time budget for this, so we should just reconcile with you.

Do you want to pass this back to the decidim_geo team?

❯ bundle exec rails decidim_geo:install:migrations
rails aborted!
LoadError: cannot load such file -- decidim/decidim_geo/api
/home/rsteiner/code/decidim-zuerich/vendor/bundle/ruby/3.0.0/gems/bootsnap-1.18.3/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:17:in `require'
/home/rsteiner/code/decidim-zuerich/vendor/bundle/ruby/3.0.0/gems/bootsnap-1.18.3/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:17:in `require'
/home/rsteiner/code/decidim-zuerich/vendor/bundle/ruby/3.0.0/gems/polyglot-0.3.5/lib/polyglot.rb:65:in `require'
/home/rsteiner/code/decidim-zuerich/vendor/bundle/ruby/3.0.0/gems/activesupport-6.1.7.7/lib/active_support/dependencies.rb:332:in `block in require'
/home/rsteiner/code/decidim-zuerich/vendor/bundle/ruby/3.0.0/gems/activesupport-6.1.7.7/lib/active_support/dependencies.rb:299:in `load_dependency'
/home/rsteiner/code/decidim-zuerich/vendor/bundle/ruby/3.0.0/gems/activesupport-6.1.7.7/lib/active_support/dependencies.rb:332:in `require'
/home/rsteiner/code/decidim-zuerich/vendor/bundle/ruby/3.0.0/bundler/gems/decidim-module-geo-fdfc76e0588a/lib/decidim/decidim_geo.rb:6:in `<main>'
/home/rsteiner/code/decidim-zuerich/config/application.rb:15:in `<main>'
/home/rsteiner/code/decidim-zuerich/Rakefile:4:in `require_relative'
/home/rsteiner/code/decidim-zuerich/Rakefile:4:in `<main>'
/home/rsteiner/code/decidim-zuerich/vendor/bundle/ruby/3.0.0/gems/railties-6.1.7.7/lib/rails/commands/rake/rake_command.rb:20:in `block in perform'
/home/rsteiner/code/decidim-zuerich/vendor/bundle/ruby/3.0.0/gems/railties-6.1.7.7/lib/rails/commands/rake/rake_command.rb:18:in `perform'
/home/rsteiner/code/decidim-zuerich/vendor/bundle/ruby/3.0.0/gems/railties-6.1.7.7/lib/rails/command.rb:50:in `invoke'
/home/rsteiner/code/decidim-zuerich/vendor/bundle/ruby/3.0.0/gems/railties-6.1.7.7/lib/rails/commands.rb:18:in `<main>'
/home/rsteiner/code/decidim-zuerich/vendor/bundle/ruby/3.0.0/gems/bootsnap-1.18.3/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:30:in `require'
/home/rsteiner/code/decidim-zuerich/vendor/bundle/ruby/3.0.0/gems/bootsnap-1.18.3/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:30:in `require'
bin/rails:4:in `<main>'

Caused by:
LoadError: cannot load such file -- decidim-decidim_geo
/home/rsteiner/code/decidim-zuerich/config/application.rb:15:in `<main>'
/home/rsteiner/code/decidim-zuerich/Rakefile:4:in `require_relative'
/home/rsteiner/code/decidim-zuerich/Rakefile:4:in `<main>'
/home/rsteiner/code/decidim-zuerich/vendor/bundle/ruby/3.0.0/gems/railties-6.1.7.7/lib/rails/commands/rake/rake_command.rb:20:in `block in perform'
/home/rsteiner/code/decidim-zuerich/vendor/bundle/ruby/3.0.0/gems/railties-6.1.7.7/lib/rails/commands/rake/rake_command.rb:18:in `perform'
/home/rsteiner/code/decidim-zuerich/vendor/bundle/ruby/3.0.0/gems/railties-6.1.7.7/lib/rails/command.rb:50:in `invoke'
/home/rsteiner/code/decidim-zuerich/vendor/bundle/ruby/3.0.0/gems/railties-6.1.7.7/lib/rails/commands.rb:18:in `<main>'
/home/rsteiner/code/decidim-zuerich/vendor/bundle/ruby/3.0.0/gems/bootsnap-1.18.3/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:30:in `require'
/home/rsteiner/code/decidim-zuerich/vendor/bundle/ruby/3.0.0/gems/bootsnap-1.18.3/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:30:in `require'
bin/rails:4:in `<main>'
(See full trace by running task with --trace)

@Robin481 Robin481 assigned larsUE and unassigned Kagemaru May 28, 2024
@froger
Copy link

froger commented May 29, 2024

Hi, @Robin481
I can make a PR today on your repo to fix the issue, you can assign me the issue for now if it's fine for you.

@larsUE larsUE assigned froger and unassigned larsUE May 29, 2024
@larsUE
Copy link
Collaborator Author

larsUE commented Jun 3, 2024

@froger do you have an update on the issue?

@nicolefreypuzzle
Copy link
Collaborator

PR wird heute eingespielt

@froger
Copy link

froger commented Jun 5, 2024

Hello @nicolefreypuzzle I've done a PR there: #439

@nicolefreypuzzle
Copy link
Collaborator

@Kagemaru Go for it :-)

@larsUE larsUE moved this from In Progress to Testable on Int in Basisplattform Mitwirken Umsetzung 2023/24 Jun 17, 2024
@larsUE larsUE moved this from Testable on Int to Deployed on PROD in Basisplattform Mitwirken Umsetzung 2023/24 Jun 24, 2024
@larsUE larsUE closed this as completed Jun 24, 2024
@larsUE larsUE moved this from Deployed on PROD to Done in Basisplattform Mitwirken Umsetzung 2023/24 Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

No branches or pull requests

5 participants