From 5730755d37644af9525e38afa7169c7648f4939d Mon Sep 17 00:00:00 2001 From: Yanick Minder <79108296+kcinay055679@users.noreply.github.com> Date: Tue, 24 Dec 2024 11:11:00 +0100 Subject: [PATCH] Refactoring/1171 naming cleanup rebase (#1263) * squash branch * regen package-lock * fix after rebase * apply formatter * implement reveiw * update hostName and subDomain --- ...ToProject.yml => add-issue-to-project.yml} | 0 .run/OkrApplication-E2E.run.xml | 2 +- .../okr/controller/CheckInController.java | 2 +- .../controller/ClientConfigController.java | 8 +- .../okr/controller/ObjectiveController.java | 8 +- .../puzzle/okr/controller/TeamController.java | 2 +- .../puzzle/okr/controller/UserController.java | 11 +- .../java/ch/puzzle/okr/dto/ActionDto.java | 2 +- .../java/ch/puzzle/okr/dto/NewUserDto.java | 2 +- .../java/ch/puzzle/okr/dto/ObjectiveDto.java | 2 +- .../main/java/ch/puzzle/okr/dto/TeamDto.java | 2 +- .../main/java/ch/puzzle/okr/dto/UserDto.java | 2 +- .../okr/dto/checkin/CheckInMetricDto.java | 2 +- .../okr/dto/checkin/CheckInOrdinalDto.java | 2 +- .../okr/dto/keyresult/KeyResultMetricDto.java | 4 +- .../dto/keyresult/KeyResultOrdinalDto.java | 2 +- .../okr/dto/keyresult/KeyResultUserDto.java | 2 +- .../puzzle/okr/dto/overview/DashboardDto.java | 6 - .../puzzle/okr/dto/overview/OverviewDto.java | 2 +- .../UserKeyResultDataDto.java | 2 +- .../UserOkrDataDto.java | 2 +- .../ch/puzzle/okr/mapper/ActionMapper.java | 2 +- .../java/ch/puzzle/okr/mapper/UserMapper.java | 12 +- .../puzzle/okr/mapper/UserOkrDataMapper.java | 4 +- .../keyresult/KeyResultMetricMapper.java | 4 +- .../keyresult/KeyResultOrdinalMapper.java | 4 +- .../java/ch/puzzle/okr/models/Action.java | 20 +- .../main/java/ch/puzzle/okr/models/User.java | 60 +- .../java/ch/puzzle/okr/models/UserTeam.java | 22 +- .../okr/multitenancy/HibernateContext.java | 2 +- .../TenantClientCustomizationProvider.java | 2 +- .../AlignmentSelectionRepository.java | 4 +- .../puzzle/okr/repository/UserRepository.java | 2 +- .../ch/puzzle/okr/security/JwtHelper.java | 16 +- .../ch/puzzle/okr/service/CacheService.java | 2 +- .../AuthorizationRegistrationService.java | 22 +- .../authorization/AuthorizationService.java | 8 +- .../UserAuthorizationService.java | 11 +- .../business/ObjectiveBusinessService.java | 10 +- .../business/QuarterBusinessService.java | 4 +- .../service/business/TeamBusinessService.java | 32 +- .../service/business/UserBusinessService.java | 10 +- .../clientconfig/ClientConfigService.java | 18 +- .../persistence/AuthorizationCriteria.java | 22 +- .../persistence/UserPersistenceService.java | 2 +- .../util/quarter/generate/QuarterLabel.java | 18 +- .../quarter/generate/h2/QuarterFunction.java | 20 +- .../main/resources/application-dev.properties | 6 +- .../application-integration-test.properties | 6 +- .../resources/application-prod.properties | 2 +- .../resources/application-staging.properties | 2 +- .../src/main/resources/application.properties | 10 +- .../afterMigrate__0_initialData.sql | 2 +- .../h2-db/data-test-h2/V100_0_0__TestData.sql | 6 +- .../V1_0_0__current-db-schema-for-testing.sql | 10 +- .../V3_1_0__renameBooleanColumns.sql | 8 + .../V3_2_0__renameFirstAndLastNameColumns.sql | 4 + .../java/ch/puzzle/okr/ForwardFilterTest.java | 2 +- .../puzzle/okr/SpringCachingConfigTest.java | 16 +- .../ch/puzzle/okr/UserKeyGeneratorTest.java | 4 +- .../okr/architecture/OkrArchitectureTest.java | 39 +- .../okr/controller/ActionControllerIT.java | 15 +- .../okr/controller/AlignmentControllerIT.java | 4 + .../okr/controller/CacheControllerIT.java | 5 +- .../okr/controller/CheckInControllerIT.java | 31 +- .../controller/ClientConfigControllerIT.java | 6 +- .../okr/controller/CompletedControllerIT.java | 6 +- .../okr/controller/KeyResultControllerIT.java | 62 +- .../okr/controller/ObjectiveControllerIT.java | 46 +- .../okr/controller/OverviewControllerIT.java | 5 + .../okr/controller/QuarterControllerIT.java | 6 +- .../okr/controller/TeamControllerIT.java | 34 +- .../okr/controller/UserControllerIT.java | 61 +- .../deserializer/CheckInDeserializerTest.java | 9 +- .../deserializer/DeserializerHelperTest.java | 4 +- .../KeyResultDeserializerTest.java | 13 +- .../puzzle/okr/mapper/ActionMapperTest.java | 18 +- .../mapper/AlignmentSelectionMapperTest.java | 16 +- .../okr/mapper/CompletedMapperTest.java | 8 +- .../okr/mapper/ObjectiveMapperTest.java | 8 +- .../puzzle/okr/mapper/OverviewMapperTest.java | 28 +- .../ch/puzzle/okr/mapper/TeamMapperTest.java | 10 +- .../ch/puzzle/okr/mapper/UserMapperTest.java | 44 +- .../okr/mapper/checkin/CheckInMapperTest.java | 24 +- .../checkin/CheckInMetricMapperTest.java | 8 +- .../checkin/CheckInOrdinalMapperTest.java | 8 +- .../mapper/checkin/helper/AssertHelper.java | 4 +- .../mapper/keyresult/KeyResultMapperTest.java | 24 +- .../keyresult/KeyResultMetricMapperTest.java | 12 +- .../keyresult/KeyResultOrdinalMapperTest.java | 12 +- .../mapper/keyresult/helper/AssertHelper.java | 8 +- .../keyresult/helper/TestDataConstants.java | 4 +- .../keyresult/helper/TestDataDtoHelper.java | 4 +- .../keyresult/helper/TestDataHelper.java | 8 +- .../authorization/AuthorizationUserTest.java | 20 +- .../okr/models/keyresult/KeyResultTest.java | 3 +- ...rrentTenantIdentifierResolverImplTest.java | 4 +- .../multitenancy/HibernateContextTest.java | 3 +- ...TenantConnectionProviderInternalsTest.java | 12 +- .../TenantConfigProviderTestIT.java | 24 +- .../okr/multitenancy/TenantContextTest.java | 5 +- ...nantClientCustomizationProviderTestIT.java | 8 +- .../security/AuthenticationEventsTest.java | 2 +- .../ch/puzzle/okr/security/JwtHelperTest.java | 32 +- .../security/TenantJWSKeySelectorTest.java | 4 +- .../TenantJwtIssuerValidatorTest.java | 6 +- .../okr/security/helper/ClaimHelperTest.java | 31 +- .../okr/security/helper/TokenHelperTest.java | 25 +- .../okr/security/helper/UrlHelperTest.java | 13 +- .../ActionAuthorizationServiceTest.java | 27 +- .../AuthorizationRegistrationServiceIT.java | 36 +- .../AuthorizationServiceTest.java | 140 +++-- .../CheckInAuthorizationServiceTest.java | 28 +- .../CompletedAuthorizationServiceTest.java | 13 +- .../KeyResultAuthorizationServiceTest.java | 44 +- .../ObjectiveAuthorizationServiceTest.java | 51 +- .../OverviewAuthorizationServiceTest.java | 29 +- .../TeamAuthorizationServiceTest.java | 39 +- .../UserAuthorizationServiceTest.java | 26 +- .../authorization/UserUpdateHelperTest.java | 22 +- .../business/ActionBusinessServiceTest.java | 27 +- .../AlignmentBusinessServiceTest.java | 13 +- ...AlignmentSelectionBusinessServiceTest.java | 4 +- .../business/CheckInBusinessServiceTest.java | 14 +- .../CompletedBusinessServiceTest.java | 7 +- .../business/KeyResultBusinessServiceIT.java | 73 ++- .../KeyResultBusinessServiceTest.java | 52 +- .../ObjectiveBusinessServiceTest.java | 43 +- .../business/OverviewBusinessServiceTest.java | 33 +- .../business/QuarterBusinessServiceTest.java | 28 +- .../business/TeamBusinessServiceTest.java | 60 +- .../business/UserBusinessServiceTest.java | 73 ++- .../clientconfig/ClientConfigServiceIT.java | 13 +- .../clientconfig/ClientConfigServiceTest.java | 26 +- .../ActionPersistenceServiceIT.java | 22 +- .../AlignmentPersistenceServiceIT.java | 8 + ...lignmentSelectionPersistenceServiceIT.java | 4 +- .../persistence/AuthorizationCriteriaIT.java | 19 +- .../AuthorizationCriteriaParametersTest.java | 14 +- .../AuthorizationCriteriaTest.java | 15 +- .../CheckInPersistenceServiceIT.java | 20 +- .../CompletedPersistenceServiceIT.java | 21 +- .../KeyResultPersistenceServiceIT.java | 54 +- .../ObjectivePersistenceServiceIT.java | 58 +- .../OverviewPersistenceServiceIT.java | 6 + .../persistence/PersistenceBaseTestIT.java | 30 +- .../QuarterPersistenceServiceIT.java | 13 +- .../persistence/TeamPersistenceServiceIT.java | 4 +- .../persistence/UserPersistenceServiceIT.java | 54 +- .../UserTeamPersistenceServiceIT.java | 4 +- .../ActionValidationServiceTest.java | 89 +-- .../AlignmentValidationServiceTest.java | 23 +- .../CheckInValidationServiceTest.java | 57 +- .../CompletedValidationServiceTest.java | 24 +- .../KeyResultValidationServiceTest.java | 61 +- .../ObjectiveValidationServiceTest.java | 127 ++-- .../OverviewValidationServiceTest.java | 12 +- .../QuarterValidationServiceTest.java | 34 +- .../validation/TeamValidationServiceTest.java | 18 +- .../validation/UserValidationServiceTest.java | 132 ++-- .../validation/ValidationBaseTest.java | 26 +- .../puzzle/okr/test/CheckInTestHelpers.java | 12 +- .../puzzle/okr/test/KeyResultTestHelpers.java | 24 +- .../java/ch/puzzle/okr/test/TestHelper.java | 32 +- .../test/dto/builder/ObjectiveDtoBuilder.java | 2 +- .../check/QuarterRangeCheckerTest.java | 36 +- .../quarter/generate/QuarterLabelTest.java | 4 +- .../util/quarter/generate/QuartersTest.java | 33 +- .../generate/h2/QuarterFunctionTest.java | 8 +- frontend/cypress.config.ts | 2 +- frontend/cypress/e2e/check-in.cy.ts | 552 ++++++++-------- .../cypress/e2e/duplicate-objective.cy.ts | 26 +- frontend/cypress/e2e/key-result.cy.ts | 64 +- frontend/cypress/e2e/login.cy.ts | 16 +- frontend/cypress/e2e/objective-backlog.cy.ts | 20 +- frontend/cypress/e2e/objective-crud.cy.ts | 16 +- frontend/cypress/e2e/objective.cy.ts | 30 +- frontend/cypress/e2e/overview.cy.ts | 10 +- frontend/cypress/e2e/routing.cy.ts | 54 +- frontend/cypress/e2e/scoring.cy.ts | 44 +- frontend/cypress/e2e/tab.cy.ts | 56 +- frontend/cypress/e2e/team-management.cy.ts | 595 ++++++++++++++++++ frontend/cypress/e2e/team.cy.ts | 278 ++++---- frontend/cypress/e2e/teammanagement.cy.ts | 595 ------------------ frontend/cypress/support/commands.ts | 6 +- .../dom-helper/dialogs/inviteMembersDialog.ts | 14 +- .../dom-helper/dialogs/keyResultDialog.ts | 24 +- .../support/helper/dom-helper/filterHelper.ts | 4 +- .../helper/dom-helper/pageObjectMapperBase.ts | 6 +- .../helper/dom-helper/pages/overviewPage.ts | 20 +- .../dom-helper/pages/teamManagementPage.ts | 74 +++ .../dom-helper/pages/teammanagementPage.ts | 74 --- frontend/package-lock.json | 134 ++-- frontend/src/app/app-routing.module.ts | 8 +- frontend/src/app/app.component.spec.ts | 4 +- frontend/src/app/app.module.ts | 22 +- .../action-plan/action-plan.component.html | 7 +- .../action-plan/action-plan.component.spec.ts | 4 +- .../application-banner.component.html | 2 +- .../application-banner.component.spec.ts | 10 +- .../application-top-bar.component.html | 20 +- .../application-top-bar.component.scss | 6 +- .../application-top-bar.component.ts | 8 +- .../check-in-history-dialog.component.html | 2 +- .../check-in-history-dialog.component.spec.ts | 2 +- .../check-in-history-dialog.component.ts | 3 +- .../metric-check-in-directive.spec.ts | 2 +- .../check-in-form-ordinal.component.spec.ts | 10 +- .../check-in-form.component.html | 6 +- .../check-in-form.component.spec.ts | 10 +- .../check-in-form/check-in-form.component.ts | 2 - .../confidence/confidence.component.html | 8 +- .../confidence/confidence.component.spec.ts | 8 +- .../confidence/confidence.component.ts | 2 +- .../key-result-detail.component.html} | 20 +- .../key-result-detail.component.scss} | 2 +- .../key-result-detail.component.spec.ts} | 16 +- .../key-result-detail.component.ts} | 18 +- .../key-result-dialog.component.html} | 4 +- .../key-result-dialog.component.scss} | 0 .../key-result-dialog.component.spec.ts} | 42 +- .../key-result-dialog.component.ts} | 12 +- .../key-result-form.component.html | 16 +- .../key-result-form.component.spec.ts | 38 +- .../key-result-form.component.ts | 18 +- .../key-result-type.component.html} | 28 +- .../key-result-type.component.scss} | 0 .../key-result-type.component.spec.ts} | 38 +- .../key-result-type.component.ts} | 20 +- .../key-result.component.html} | 8 +- .../key-result.component.scss} | 0 .../key-result.component.spec.ts} | 12 +- .../key-result.component.ts} | 8 +- .../objective-detail.component.html | 8 +- .../objective-detail.component.spec.ts | 8 +- .../objective-detail.component.ts | 4 +- .../objective-filter.component.html | 2 +- .../objective-filter.component.spec.ts | 10 +- .../objective-filter.component.ts | 4 +- .../objective/objective.component.html | 7 +- .../objective/objective.component.spec.ts | 43 +- .../objective/objective.component.ts | 4 +- .../overview/overview.component.html | 6 +- .../overview/overview.component.spec.ts | 10 +- .../quarter-filter.component.html | 2 +- .../team-filter/team-filter.component.html | 6 +- .../team-filter/team-filter.component.spec.ts | 30 +- .../app/components/team/team.component.html | 4 +- .../components/team/team.component.spec.ts | 6 +- .../src/app/components/team/team.component.ts | 4 +- frontend/src/app/guards/auth.guard.spec.ts | 6 +- frontend/src/app/guards/auth.guard.ts | 10 +- .../interceptors/error.interceptor.spec.ts | 78 +-- ...ceptor.service.ts => error.interceptor.ts} | 4 +- ...tor.spec.ts => o-auth.interceptor.spec.ts} | 6 +- ...h.interceptor.ts => o-auth.interceptor.ts} | 10 +- frontend/src/app/services/check-in.service.ts | 4 +- .../objective-menu-actions.service.spec.ts | 39 +- .../src/app/services/toaster.service.spec.ts | 32 +- .../src/app/services/user.service.spec.ts | 20 +- frontend/src/app/shared/constantLibary.ts | 15 +- .../custom/scoring/scoring.component.html | 2 +- .../custom/scoring/scoring.component.scss | 2 +- .../custom/scoring/scoring.component.spec.ts | 4 +- .../custom/scoring/scoring.component.ts | 14 +- .../example-dialog.component.html | 59 -- .../example-dialog.component.spec.ts | 207 ------ .../example-dialog.component.ts | 48 -- .../objective-form.component.spec.ts | 8 +- .../unit-transformation.pipe.spec.ts | 22 +- frontend/src/app/shared/shared.module.ts | 9 +- .../side-panel.component.html} | 2 +- .../side-panel.component.scss} | 2 +- .../side-panel.component.ts} | 8 +- frontend/src/app/shared/testData.ts | 68 +- frontend/src/app/shared/types/menu-entry.ts | 11 - .../src/app/shared/types/model/CheckIn.ts | 2 +- .../src/app/shared/types/model/CheckInMin.ts | 2 +- .../src/app/shared/types/model/KeyResult.ts | 2 +- .../src/app/shared/types/model/NewUser.ts | 4 +- .../src/app/shared/types/model/NewUserForm.ts | 4 +- .../src/app/shared/types/model/Objective.ts | 2 +- .../app/shared/types/model/OverviewEntity.ts | 2 +- frontend/src/app/shared/types/model/Team.ts | 2 +- frontend/src/app/shared/types/model/User.ts | 8 +- .../app/shared/types/model/UserTableEntry.ts | 10 +- .../add-edit-team-dialog.component.scss | 4 - .../add-edit-team-dialog.component.spec.ts | 10 +- ...dd-member-to-team-dialog.component.spec.ts | 6 +- .../add-member-to-team-dialog.component.ts | 2 +- .../add-user-team.component.html | 8 +- .../add-user-team.component.spec.ts | 34 +- .../add-user-team/add-user-team.component.ts | 8 +- .../delete-user/delete-user.component.spec.ts | 16 +- .../delete-user/delete-user.component.ts | 14 +- .../invite-user-dialog.component.spec.ts | 22 +- .../invite-user-dialog.component.ts | 4 +- .../member-detail.component.html | 2 +- .../member-detail/member-detail.component.ts | 14 +- .../member-list-mobile.component.ts | 4 +- .../member-list-table.component.html | 4 +- .../member-list-table.component.spec.ts | 10 +- .../member-list-table.component.ts | 4 +- .../member-list/member-list.component.html | 4 +- .../member-list/member-list.component.spec.ts | 14 +- .../member-list/member-list.component.ts | 2 +- .../new-user/new-user.component.html | 28 +- .../new-user/new-user.component.spec.ts | 4 +- .../new-user/new-user.component.ts | 8 +- .../team-management/okr-champion.pipe.spec.ts | 2 +- .../search-team-management.component.spec.ts | 21 +- .../search-team-management.component.ts | 8 +- .../show-edit-role.component.scss | 1 + .../show-edit-role.component.spec.ts | 5 +- .../show-edit-role.component.ts | 2 +- .../team-management-banner.component.html | 2 +- .../team-management-banner.component.scss | 2 +- ...management-mobile-filter.component.spec.ts | 4 +- .../team-management-routing.module.ts | 4 +- .../team-role-dropdown.component.spec.ts | 4 +- frontend/src/assets/i18n/de.json | 2 +- frontend/src/style/_variables.scss | 4 +- frontend/src/style/custom_bootstrap.scss | 2 +- frontend/src/style/styles.scss | 20 +- 324 files changed, 3839 insertions(+), 3801 deletions(-) rename .github/workflows/{addIssueToProject.yml => add-issue-to-project.yml} (100%) delete mode 100644 backend/src/main/java/ch/puzzle/okr/dto/overview/DashboardDto.java rename backend/src/main/java/ch/puzzle/okr/dto/{userOkrData => userokrdata}/UserKeyResultDataDto.java (75%) rename backend/src/main/java/ch/puzzle/okr/dto/{userOkrData => userokrdata}/UserOkrDataDto.java (71%) create mode 100644 backend/src/main/resources/db/migration/V3_1_0__renameBooleanColumns.sql create mode 100644 backend/src/main/resources/db/migration/V3_2_0__renameFirstAndLastNameColumns.sql create mode 100644 frontend/cypress/e2e/team-management.cy.ts create mode 100644 frontend/cypress/support/helper/dom-helper/pages/teamManagementPage.ts rename frontend/src/app/components/{keyresult-detail/keyresult-detail.component.html => key-result-detail/key-result-detail.component.html} (88%) rename frontend/src/app/components/{keyresult-detail/keyresult-detail.component.scss => key-result-detail/key-result-detail.component.scss} (97%) rename frontend/src/app/components/{keyresult-detail/keyresult-detail.component.spec.ts => key-result-detail/key-result-detail.component.spec.ts} (88%) rename frontend/src/app/components/{keyresult-detail/keyresult-detail.component.ts => key-result-detail/key-result-detail.component.ts} (90%) rename frontend/src/app/components/{keyresult-dialog/keyresult-dialog.component.html => key-result-dialog/key-result-dialog.component.html} (92%) rename frontend/src/app/components/{keyresult-dialog/keyresult-dialog.component.scss => key-result-dialog/key-result-dialog.component.scss} (100%) rename frontend/src/app/components/{keyresult-dialog/keyresult-dialog.component.spec.ts => key-result-dialog/key-result-dialog.component.spec.ts} (94%) rename frontend/src/app/components/{keyresult-dialog/keyresult-dialog.component.ts => key-result-dialog/key-result-dialog.component.ts} (92%) rename frontend/src/app/components/{keyresult-type/keyresult-type.component.html => key-result-type/key-result-type.component.html} (85%) rename frontend/src/app/components/{keyresult-type/keyresult-type.component.scss => key-result-type/key-result-type.component.scss} (100%) rename frontend/src/app/components/{keyresult-type/keyresult-type.component.spec.ts => key-result-type/key-result-type.component.spec.ts} (91%) rename frontend/src/app/components/{keyresult-type/keyresult-type.component.ts => key-result-type/key-result-type.component.ts} (89%) rename frontend/src/app/components/{keyresult/keyresult.component.html => key-result/key-result.component.html} (87%) rename frontend/src/app/components/{keyresult/keyresult.component.scss => key-result/key-result.component.scss} (100%) rename frontend/src/app/components/{keyresult/keyresult.component.spec.ts => key-result/key-result.component.spec.ts} (75%) rename frontend/src/app/components/{keyresult/keyresult.component.ts => key-result/key-result.component.ts} (86%) rename frontend/src/app/interceptors/{error-interceptor.service.ts => error.interceptor.ts} (96%) rename frontend/src/app/interceptors/{oauth.interceptor.spec.ts => o-auth.interceptor.spec.ts} (77%) rename frontend/src/app/interceptors/{oauth.interceptor.ts => o-auth.interceptor.ts} (76%) delete mode 100644 frontend/src/app/shared/dialog/example-dialog/example-dialog.component.html delete mode 100644 frontend/src/app/shared/dialog/example-dialog/example-dialog.component.spec.ts delete mode 100644 frontend/src/app/shared/dialog/example-dialog/example-dialog.component.ts rename frontend/src/app/shared/{sidepanel/sidepanel.component.html => side-panel/side-panel.component.html} (93%) rename frontend/src/app/shared/{sidepanel/sidepanel.component.scss => side-panel/side-panel.component.scss} (93%) rename frontend/src/app/shared/{sidepanel/sidepanel.component.ts => side-panel/side-panel.component.ts} (86%) delete mode 100644 frontend/src/app/shared/types/menu-entry.ts diff --git a/.github/workflows/addIssueToProject.yml b/.github/workflows/add-issue-to-project.yml similarity index 100% rename from .github/workflows/addIssueToProject.yml rename to .github/workflows/add-issue-to-project.yml diff --git a/.run/OkrApplication-E2E.run.xml b/.run/OkrApplication-E2E.run.xml index 4d2c9a4905..aa7706165a 100644 --- a/.run/OkrApplication-E2E.run.xml +++ b/.run/OkrApplication-E2E.run.xml @@ -1,7 +1,7 @@