Feature/1077 different db users v2 #1123
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MasterEvarior
force-pushed
the
dev
branch
2 times, most recently
from
be0495f to
edd0dee
Compare
peggimann
force-pushed
the
feature/1077_different_db_users_v2
branch
from
401b58b to
58b8c27
Compare
RandomTannenbaum
force-pushed
the
feature/1077_different_db_users_v2
branch
from
22e0350 to
b9be875
Compare
ManuelMoeri
force-pushed
the
feature/1077_different_db_users_v2
branch
from
b9be875 to
ca39cd9
Compare
MasterEvarior
requested changes
Nov 21, 2024
There was a problem hiding this comment.
Hab mir mal die Freiheit genommen einen Blick darüber zu werfen, folgendes ist mir aufgefallen:
- es hat noch einige Log-Statements mit dem
error-Level, welche nicht viel mit Errors zu tun haben - Enum ist nicht nach Java Convention benannt
Sonst sieht alles OK aus für mich. Die Kommentare sind super, sie helfen extrem beim Verständnis! Auf der Datenbank habe ich kurz die Berechtigungen für die Schemas getestet, scheint auch alles zu funktionieren.
backend/src/main/java/ch/puzzle/okr/multitenancy/TenantConfigProvider.java
Outdated
Show resolved
Hide resolved
backend/src/main/java/ch/puzzle/okr/multitenancy/FlywayMultitenantMigrationInitializer.java
Outdated
Show resolved
Hide resolved
backend/src/main/java/ch/puzzle/okr/multitenancy/HibernateContext.java
Outdated
Show resolved
Hide resolved
backend/src/main/java/ch/puzzle/okr/multitenancy/HibernateContext.java
Outdated
Show resolved
Hide resolved
backend/src/main/java/ch/puzzle/okr/multitenancy/HibernateContext.java
Outdated
Show resolved
Hide resolved
backend/src/main/java/ch/puzzle/okr/multitenancy/TenantConfigProvider.java
Outdated
Show resolved
Hide resolved
backend/src/test/java/ch/puzzle/okr/multitenancy/HibernateContextTest.java
Outdated
Show resolved
Hide resolved
peggimann
reviewed
Nov 25, 2024
backend/src/main/java/ch/puzzle/okr/multitenancy/SchemaMultiTenantConnectionProvider.java
Show resolved
Hide resolved
backend/src/main/java/ch/puzzle/okr/multitenancy/SchemaMultiTenantConnectionProvider.java
Outdated
Show resolved
Hide resolved
backend/src/main/java/ch/puzzle/okr/multitenancy/SchemaMultiTenantConnectionProvider.java
Show resolved
Hide resolved
backend/src/main/java/ch/puzzle/okr/multitenancy/TenantConfigProvider.java
Show resolved
Hide resolved
backend/src/main/java/ch/puzzle/okr/multitenancy/FlywayMultitenantMigrationInitializer.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.