Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PTime API | PuzzleTime Sync #5 #744

Open
5 tasks
kcinay055679 opened this issue Jul 2, 2024 · 0 comments
Open
5 tasks

Update PTime API | PuzzleTime Sync #5 #744

kcinay055679 opened this issue Jul 2, 2024 · 0 comments

Comments

@kcinay055679
Copy link
Collaborator

kcinay055679 commented Jul 2, 2024

Introduction
At the moment, the PuzzleTime API doesn't provide us with all the data necessary to create a new Person if we need to. To be able to do this, a few new fields need to be added to the API. These fields are:

  • city
  • birthdate
  • nationality
  • active member flag

We also have noticed, that we get a field with employment_roles from the API, which is an array, but it is always empty. Take a look at what it is, if it is broken somehow and if it maybe even is helpful for us.

ToDo

  • Fork PuzzleTime repo if you dont have access and setup the project locally
  • Add all missing fields to the /api/v1/employee endpoint of PTIme
  • Check the /api/v1/employee/1 endpoint, it should return the correct data
  • update Tests
  • Create PR on PuzzleTime repo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant