Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt Puzzle Shell #792

Open
hupf opened this issue Feb 4, 2025 · 1 comment
Open

Adopt Puzzle Shell #792

hupf opened this issue Feb 4, 2025 · 1 comment
Labels
plan needs to be planned

Comments

@hupf
Copy link
Member

hupf commented Feb 4, 2025

With the Puzzle Shell, we have a standard design for our tools & solutions – many other project already use it:

https://github.com/puzzle/puzzle-shell

We should adopt Puzzle Shell as the base layout for Puzzle Skills to achieve a unique look over the various apps. I'd also be happy to support, if needed...

@Robin481
Copy link
Member

Robin481 commented Feb 4, 2025

We did kind of use it at one point and it is still included and works:

= stylesheet_link_tag "application", "https://unpkg.com/@puzzleitc/puzzle-shell/dist/style.css"

%pzsh-icon.scale-icon-08.text-gray(name="question-circle")

However, last time we wanted to use it for the applications' header we struggled to make it work properly and decided that it wasn't worth the effort. The focus back then was on just making the application work again without EmberJS.

As the application is now in relatively stable state, revisiting this seems like a reasonable suggestion to me.

It certainly won't be a priority over the more functional features but we'll see how far we get.

@Robin481 Robin481 added the plan needs to be planned label Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plan needs to be planned
Projects
None yet
Development

No branches or pull requests

2 participants