Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JPEG: Process Files does not seem to adjust brightness #4

Open
csghone opened this issue Jun 18, 2016 · 7 comments
Open

JPEG: Process Files does not seem to adjust brightness #4

csghone opened this issue Jun 18, 2016 · 7 comments
Assignees

Comments

@csghone
Copy link
Collaborator

csghone commented Jun 18, 2016

No description provided.

@csghone csghone assigned csghone and unassigned csghone Jun 18, 2016
@pvishal
Copy link
Owner

pvishal commented Jun 18, 2016

I have not seen this part of the code but is there any brightness adjustment in the code? The RAW workflow relies on RT or ACR to do the real work.

@csghone
Copy link
Collaborator Author

csghone commented Jun 19, 2016

Process8bit in ProjectLS.cs. Seems to be correct at a glance - but output files end up with identical brightness. Infact, if I give the output files back as input, the new output files are bit-exact!

@csghone
Copy link
Collaborator Author

csghone commented Jun 19, 2016

It seems to call Bitmap.Save(savePath) - I guess it is expected to work only for BMP!

@csghone
Copy link
Collaborator Author

csghone commented Jun 19, 2016

It supports only BMP flow.
I can probably try to force output type via ffmpeg. What do you think?

@csghone
Copy link
Collaborator Author

csghone commented Jun 19, 2016

Even in BMP the output data doesn't seem to change

@pvishal
Copy link
Owner

pvishal commented Jun 19, 2016

That might just be true. I had run the the output images back through this software and got the same brightness curve. I'll look into this. The output file extension seems to change as you change the 'Output file' in settings but that doesn't mean anything. I miss the file command here on Windows.

@csghone
Copy link
Collaborator Author

csghone commented Jun 20, 2016

On Sun, Jun 19, 2016 at 11:24 PM, Vishal Prabhu [email protected]
wrote:

That might just be true. I had run the the output images back through this
software and got the same brightness curve. I'll look into this. The output
file extension seems to change as you change the 'Output file' in settings
but that doesn't mean anything. I miss the file command here on Windows.

Install MSYS2. Installation steps at
https://wiki.allegro.cc/index.php?title=Building_with_msys2
Ignore the Allegro part...

Then, "pacman -Syu file"


Chaitanya S. Ghone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants