Consider formal design spec documents #1770
kandersolar
started this conversation in
General
Replies: 2 comments
-
I think this would be great! Developing this for the transposition/decomposition models would probably also require a good amount of cleanup/standardization of the current functions, which I suspect is unlikely to happen in the near future. I posted an initial design spec in #1528 |
Beta Was this translation helpful? Give feedback.
0 replies
-
To the list above, I would add normalizing some parameter names #825 and function name patterns. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Several aspects of pvlib's functionality and interface follow semi-official, but poorly documented, conventions. Here is a short list of cases where we have aligned, or would like to align some aspect of functions that are alternatives to each other in some sense:
return_components
in all transposition model functions #1553iotools
:map_variables
,return data, metadata
,requests.get(..., **kwargs)
,get/read
These conventions are great, and I'd like to see more of them. The problem is that they aren't easy to discover. I can think of a few possible benefits of making them more visible:
I think the project would benefit from some central listing of these kinds of standards/conventions. The goal would be to provide consolidated documentation of aspects of pvlib's design that are too broad or high-level to put in any one function-level docstring. The Variables and Symbols page is an example of the kind of page I am imagining.
One thing that comes to mind is how some projects have their own version of PEPs (e.g. NumPy and Astropy), and there is also SPECs, although I don't know if that level of formality is necessary or desirable in our case.
Beta Was this translation helpful? Give feedback.
All reactions