Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{Linked:Bug214446; LinkedBug} [DOCS]: Keyboard focus get lost after activating Home tab item present in left navigation pane. #4274

Closed
Anshi0420 opened this issue Aug 11, 2023 · 11 comments
Labels
A11y-3P A11yExternal A11ySev2 Accessibility Team tag - P2 items A11yWCAG Accessibility Team tag - Web Content Accessibility Guidelines Accessibility [E+D] Issues found by the accessibility E+D Team at Microsoft bug 🐛 CT-July23 CT-June24 external-dependency HCL-E+D needs attention 👋 needs triage 🔍 Product-PWABuilder For Tracking PWABuilder bugs by Accessibility E+D team PWABuilder_Web

Comments

@Anshi0420
Copy link
Collaborator

Anshi0420 commented Aug 11, 2023

What happened?

After activating home tab item focus gets lost and after pressing tab key focus land on the GIT hub icon present at the page.

How do we reproduce the behavior?

Repro Steps:

  1. Open the PWA Builder URL in Anaheim dev browser.
  2. PWA Builder page will appear.
  3. Navigate to the home tab item present in the left navigation pane and activate it.
  4. Again press tab key to observe the keyboard focus.
  5. Observe the issue.

What do you expect to happen?

Focus should remain on the home tab item after activating it, it should not get lost and should not land on the Git hub icon.

What environment were you using?

Test Environment:
OS Build: Windows 11 Enterprise Insider Preview 22H2 (23493.1000)
Edge Browser: Version 115.0.1880.3 (Official build) dev (64-bit)
User ID: V-
URL: https://docs.pwabuilder.com/#/

Additional context

Note:
After closing any dialogue such as 'Edit your Manifest' present at https://www.pwabuilder.com/reportcard?site=https://webboard.app focus get lost and land on the top of the page.
Expected:
Focus should remain on the Activated button.

User Experience:
If the keyboard focus will get lost and land on the top of the UI, then the keyboard and screen reader dependent users need to press multiple times tab to reach again on that control and will face difficulties in navigating at the UI properly.

WCAG Reference:
https://www.w3.org/WAI/WCAG21/Understanding/focus-order.html

Attachments:

Focus.mp4

Note attachment:

2023-08-11.17-06-52.mp4
@Anshi0420 Anshi0420 added bug 🐛 needs triage 🔍 A11yWCAG Accessibility Team tag - Web Content Accessibility Guidelines Accessibility [E+D] Issues found by the accessibility E+D Team at Microsoft A11ySev2 Accessibility Team tag - P2 items Product-PWABuilder For Tracking PWABuilder bugs by Accessibility E+D team HCL-E+D CT-July23 labels Aug 11, 2023
@microsoft-github-policy-service
Copy link
Contributor

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .

1 similar comment
@microsoft-github-policy-service
Copy link
Contributor

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .

@Jaylyn-Barbee Jaylyn-Barbee changed the title [PWA Builder-Blog]: Keyboard focus get lost after activating Home tab item present in left navigation pane. [DOCS]: Keyboard focus get lost after activating Home tab item present in left navigation pane. Aug 28, 2023
@Jaylyn-Barbee
Copy link
Contributor

Jaylyn-Barbee commented Aug 28, 2023

@Anshi0420, why does it seem like the main issue and the additional context here are separate issues or is this just another example of the same issue?

@maraah1 maraah1 self-assigned this Aug 30, 2023
@maraah1 maraah1 moved this to In Progress 🚧 in PWABuilder Sep 5, 2023
@microsoft-github-policy-service
Copy link
Contributor

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .

@microsoft-github-policy-service
Copy link
Contributor

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .

1 similar comment
@microsoft-github-policy-service
Copy link
Contributor

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .

@Jaylyn-Barbee Jaylyn-Barbee removed the status in PWABuilder Oct 2, 2023
@zateutsch zateutsch moved this to Blocked 🔒 in PWABuilder Oct 4, 2023
@microsoft-github-policy-service
Copy link
Contributor

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .

1 similar comment
@microsoft-github-policy-service
Copy link
Contributor

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .

@Anshi0420 Anshi0420 changed the title [DOCS]: Keyboard focus get lost after activating Home tab item present in left navigation pane. {Linked:Bug214446, LinkedBug} [DOCS]: Keyboard focus get lost after activating Home tab item present in left navigation pane. Oct 17, 2023
@Suriya617
Copy link
Collaborator

IRT partner bug ID for tracking: https://dev.azure.com/CSS-IRT/CSS%20IRT/_workitems/edit/214446

@github-project-automation github-project-automation bot moved this from Blocked 🔒 to Done ✔️ in PWABuilder Oct 18, 2023
@Anshi0420 Anshi0420 changed the title {Linked:Bug214446, LinkedBug} [DOCS]: Keyboard focus get lost after activating Home tab item present in left navigation pane. {Linked:Bug214446} [DOCS]: Keyboard focus get lost after activating Home tab item present in left navigation pane. Oct 20, 2023
@Anshi0420 Anshi0420 changed the title {Linked:Bug214446} [DOCS]: Keyboard focus get lost after activating Home tab item present in left navigation pane. {Linked:Bug214446; LinkedBug} [DOCS]: Keyboard focus get lost after activating Home tab item present in left navigation pane. Oct 20, 2023
@Suriya617
Copy link
Collaborator

@Jaylyn-Barbee Comment from 3P team:

This issue is closed by third party as fixed with the below comment-

Fixed via #2253 (Opens in new window or tab) and #2265 (Opens in new window or tab).
These updates will be available in the next release. Until then, you can verify the changes by visiting the develop branch preview (Opens in new window or tab). Thanks

@Anshi0420
Copy link
Collaborator Author

Issue still repro at the latest environment.
https://docs.pwabuilder.com/#/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A11y-3P A11yExternal A11ySev2 Accessibility Team tag - P2 items A11yWCAG Accessibility Team tag - Web Content Accessibility Guidelines Accessibility [E+D] Issues found by the accessibility E+D Team at Microsoft bug 🐛 CT-July23 CT-June24 external-dependency HCL-E+D needs attention 👋 needs triage 🔍 Product-PWABuilder For Tracking PWABuilder bugs by Accessibility E+D team PWABuilder_Web
Projects
Status: Done ✔️
Development

No branches or pull requests

4 participants