Quick look into PRs #829
Comments
ldelossa
added a commit
to ldelossa/octo.nvim
that referenced
this issue
Jan 29, 2025
Add a new command `Octo review browse` which opens the review layout for a PR but does not start a review. This is handy when you want to look over the changes in a PR but do not necessary want to review it. When you are in a Review layout initiated by `Octo review browse` you can intuitively convert it into an active review session with `Octo review start`. Its invalid to call `Octo review browse` after `Octo review start` and the user must either submit or discard the active review to enter the browse state again. Closes: pwntester#829 Signed-off-by: ldelossa <[email protected]>
2 tasks
ldelossa
added a commit
to ldelossa/octo.nvim
that referenced
this issue
Jan 29, 2025
Add a new command `Octo review browse` which opens the review layout for a PR but does not start a review. This is handy when you want to look over the changes in a PR but do not necessary want to review it. When you are in a Review layout initiated by `Octo review browse` you can intuitively convert it into an active review session with `Octo review start`. Its invalid to call `Octo review browse` after `Octo review start` and the user must either submit or discard the active review to enter the browse state again. Closes: pwntester#829 Signed-off-by: ldelossa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
A bit of a thought about this. It would be cool if "checkout" means it also loads up the review layout (but does not start a review just yet)
Sometimes, you may want to look at a PR's details (changed files, comments, comment threads in their relation to source code), but have no desire to add a review. You may just want to browse the changes and read comments. Right now, this required you to start a review, right?
If so, it would be nice to make "checkout" command load up what is currently the review layout, and then make "review.start" actually start a review. In other words, the review.start functionality today just becomes a subset of the mode youre put in when you do "checkout"
Originally posted by @ldelossa in #814 (comment)
The text was updated successfully, but these errors were encountered: