Skip to content

Basic backgrounds input validation #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Revile77 opened this issue Jan 4, 2019 · 0 comments
Open

Basic backgrounds input validation #3

Revile77 opened this issue Jan 4, 2019 · 0 comments

Comments

@Revile77
Copy link

Revile77 commented Jan 4, 2019

Currently, there are no checks in PyFBU whether user correctly specified backgrounds and their corresponding normalization uncertainties. Specifically, it may naively seem to the user that if one specifies background A in pyFBU.backgrounds but omits A from the background normalization syst dictionary pyFBU.backgroundsyst, that normalization uncertainty will be set to zero.
This assumption is wrong, since PyFBU actually builds the backgrounds in likelihood using the keys from the background normalization uncertainties dictionary:
backgroundkeys = self.backgroundsyst.keys()
So omitting a background normalization uncertainty key from the dictionary will cause this background to be silently dropped from the likelihood completely.

I would propose a (IMHO transparent) solution to compare the keys in pyFBU.backgrounds and pyFBU.backgroundsyst and print some error message to the user if these are not identical.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant