Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor pytest fixtures into a pytest-growler plugin #13

Open
lmergner opened this issue Aug 29, 2016 · 3 comments
Open

Refactor pytest fixtures into a pytest-growler plugin #13

lmergner opened this issue Aug 29, 2016 · 3 comments

Comments

@lmergner
Copy link

lmergner commented Aug 29, 2016

I'm copying tests from growler-mako into my extension, so it's probably a good idea to eventually consolidate common fixtures into a pytest plugin at some future point.

@akubera
Copy link
Member

akubera commented Aug 29, 2016

Yes, this is on my (long) to-do list for Growler.

@lmergner
Copy link
Author

I figured. Is it helpful to leave these ideas as issues?

@akubera
Copy link
Member

akubera commented Aug 29, 2016

Yes I believe so. Besides offering a place for discussion, a public list of things that need to be worked on is a good motivator.

What I really need for this issue is a person or guide that can explain best practices for organizing a good pytest module. It looks like I was starting to do a refactor in tests/mock_classes.py, but that was about a year ago. As growler has changed a lot since I started it (>2 years!?! my, how time flies) I haven't really worried about adding support libraries. Since it's starting to solidify and I'm pretty happy with its structure, I will probably look into this (assuming people use it, making it worth my time).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants