Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: date for (one) review - 9/1/2022 instead of 09/01/2022 #130

Open
lwasser opened this issue Mar 9, 2024 · 1 comment
Open

BUG: date for (one) review - 9/1/2022 instead of 09/01/2022 #130

lwasser opened this issue Mar 9, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@lwasser
Copy link
Member

lwasser commented Mar 9, 2024

The pygmt review has a slight unusual date format (thanks to me!) that looks like this

Screenshot 2024-03-08 at 6 20 50 PM

because there are no 0's before the month and day, it then is added to our yaml data without quotes. so if we wanted to use this date in the future, it would cause parsing problems. It probably makes sense to add a step to the ReviewModel validator for date_Accepted that looks for single digit values and adds a 0 before.

@lwasser
Copy link
Member Author

lwasser commented Jul 4, 2024

this will be closed if we address #179

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants