Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: code that requires a dependency or two #20

Open
lwasser opened this issue Jun 24, 2024 · 2 comments · May be fixed by #38
Open

Add: code that requires a dependency or two #20

lwasser opened this issue Jun 24, 2024 · 2 comments · May be fixed by #38

Comments

@lwasser
Copy link
Member

lwasser commented Jun 24, 2024

Right now the code base is super simple and as such there are no dependencies.

Because most packages do have dependencies we should enhance the code some to include other packages that we can then add as dependencies to our pyproject.toml file.

Maybe pandas and we could have the package generate plots with altair? or perhaps others have an idea as to what functionality this could have.

@lwasser
Copy link
Member Author

lwasser commented Jun 24, 2024

i think we could actually add the modules that @ucodery added here to this example. thus we have a simple add_numbers for teaching and a few other modules with dependencies for a more robust package setup.

Let's start with basic code and then we can make it more robust, add more tests etc later. even add a class - that might be good. (in a separate issue)

@ucodery
Copy link

ucodery commented Jun 24, 2024

Are you wanting to make examplePy a dependency of this package? That won't work without some complex build setup as examplePy isn't a published project. Probably better to add pandas like you were originally thinking.

@gpcureton gpcureton linked a pull request Jul 13, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants