Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #20. Added some dependencies #38

Conversation

gpcureton
Copy link

Closes #20 . Added routine for multiplying integers, an plotting an image using Altair.

@gpcureton gpcureton marked this pull request as ready for review July 13, 2024 23:28
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey there @gpcureton thank you for this PR! the one challenge here that we need to think through is we can't delete this add_numbers.py module. this is because we use it in our trainings as an example module that people make. And in our tutorials as well. it's a core simple module that people can quickly make without thinking much about the code within the function there.

So we want user to be able to access this add_numbers.py module.

I'd prefer to keep the add_numbers module as is. BUT we can then rename your simple_arithmetic module to be something more specific that includes numpy or another package.

Let me know what you think.

@lwasser
Copy link
Member

lwasser commented Oct 24, 2024

hey @gpcureton, thank you again for your contributions here. !! i am going to close this pr for the time being! i hope all is well!!

@lwasser
Copy link
Member

lwasser commented Oct 24, 2024

@all-contributors please add @gpcureton for code, review

Copy link
Contributor

@lwasser

I've put up a pull request to add @gpcureton! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Add: code that requires a dependency or two
2 participants