-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Great Tables submission #202
Comments
Editor in Chief checksHi there! Thank you for submitting your package for pyOpenSci review. Below are the basic checks that your package needs to pass to begin our review. If some of these are missing, we will ask you to work on them before the review process begins. Please check our Python packaging guide for more information on the elements
Editor commentsThis is a really solid submission, and I am super excited for us to contribute to suggestion: TIL we can store CONTRIBUTING.md in todo: We can get started, but during the review's course, we should add the |
Hi @rich-iannone, thanks again for submitting Great Tables to pyOpenSci! |
Hello there @rich-iannone, |
Hey @rich-iannone, @glemaitre and @cjbassin, thank you so much or volunteering to review for pyOpenSci! I hope this experience will be as fulfilling as it was for me. Please fill out our pre-review surveyBefore beginning your review, please fill out our pre-review survey. This helps us improve all aspects of our review and better understand our community. No personal data will be shared from this survey - it will only be used in an aggregated format by our Executive Director to improve our processes and programs.
The following resources will help you complete your review:
Please get in touch with any questions or concerns! Your review is due: 18th nov.Reviewers: @glemaitre,@cjbassin |
Hi-I am beginning the review but noticed that the original issue had a v0.9.0 version in the issue request, where as it looks like substantial improvements have been made in new releases since then, and its currently at v0.13.0. Should I install the older version or would the preference be to do a review on the current version?On Oct 26, 2024, at 12:34 PM, Alex Batisse ***@***.***> wrote:
Hey @rich-iannone,
Sorry, it took me so long to get back to this review. Let me make it up to you by introducing the two rock stars who volunteered to review great-tables: @glemaitre and @cjbassin.
@glemaitre and @cjbassin, thank you so much or volunteering to review for pyOpenSci! I hope this experience will be as fulfilling as it was for me.
Please fill out our pre-review survey
Before beginning your review, please fill out our pre-review survey. This helps us improve all aspects of our review and better understand our community. No personal data will be shared from this survey - it will only be used in an aggregated format by our Executive Director to improve our processes and programs.
@glemaitre survey completed.
@cjbassin survey completed.
The following resources will help you complete your review:
Here is the reviewers guide. This guide contains all of the steps and information needed to complete your review.
Here is the review template that you will need to fill out and submit
here as a comment, once your review is complete.
Please get in touch with any questions or concerns! Your review is due: 18th nov.
Reviewers: @***@***.***
Due date: 2024/11/18
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
@cjbassin Thanks for noting this! I'd definitely appreciate it if the review were based on v0.13.0 version. |
Absolutely, I updated the version. Thank you |
Submitting Author: Name (@rich-iannone)
All current maintainers: (@rich-iannone, @machow)
Package Name: Great Tables
One-Line Description of Package: Make awesome display tables using Python.
Repository Link: https://github.com/posit-dev/great-tables
Version submitted: v0.13.0
EiC: @Batalex
Editor: @Batalex
Reviewer 1: TBD
Reviewer 2: TBD
Archive: TBD
JOSS DOI: TBD
Version accepted: TBD
Date accepted (month/day/year): TBD
Code of Conduct & Commitment to Maintain Package
Description
The Great Tables package is all about creating tables for the purpose of presentation. You can use
Pandas or Polars DataFrames as inputs, and the Great Tables API allows you to:
as HTML or a variety of image formats
Scope
Please indicate which category or categories.
Check out our package scope page to learn more about our
scope. (If you are unsure of which category you fit, we suggest you make a pre-submission inquiry):
Domain Specific
Community Partnerships
If your package is associated with an
existing community please check below:
The package can be seen as a data visualization package, but it is perhaps more in the direction of data presentation/publication (i.e., not datavis in the traditional sense). However, tables are important and they are ubiquitous in all sorts of scientific publications.
The target audience is anyone who needs to present data in the tabular format. There is a particular focus on science and engineering applications as many of the formatting methods are geared toward this audience (e.g., scientific notation, significant figures, units notation, chemistry notation, etc.).
There are only a few packages that deal with tabular data presentation. The Pandas styler API is probably the best known of these, but it is limited in its capabilities. A big part of Great Tables is the ability to structure a table to a more traditional table format (one you'd commonly see in journals or reports) instead of interactive tables that are more common in web apps (i.e., displaying hundreds or thousands of rows of data). The formatting capabilities of Great Tables are also much more extensive than Pandas styler or other packages.
@tag
the editor you contacted:#184
Technical checks
For details about the pyOpenSci packaging requirements, see our packaging guide. Confirm each of the following by checking the box. This package:
Publication Options
JOSS Checks
paper.md
matching JOSS's requirements with a high-level description in the package root or ininst/
.Note: JOSS accepts our review as theirs. You will NOT need to go through another full review. JOSS will only review your paper.md file. Be sure to link to this pyOpenSci issue when a JOSS issue is opened for your package. Also be sure to tell the JOSS editor that this is a pyOpenSci reviewed package once you reach this step.
Are you OK with Reviewers Submitting Issues and/or pull requests to your Repo Directly?
This option will allow reviewers to open smaller issues that can then be linked to PR's rather than submitting a more dense text based review. It will also allow you to demonstrate addressing the issue via PR links.
Confirm each of the following by checking the box.
Please fill out our survey
submission and improve our peer review process. We will also ask our reviewers
and editors to fill this out.
P.S. Have feedback/comments about our review process? Leave a comment here
Editor and Review Templates
The editor template can be found here.
The review template can be found here.
Footnotes
Please fill out a pre-submission inquiry before submitting a data visualization package. ↩
The text was updated successfully, but these errors were encountered: