Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Great Tables submission #202

Open
17 of 31 tasks
rich-iannone opened this issue Jun 14, 2024 · 7 comments
Open
17 of 31 tasks

Great Tables submission #202

rich-iannone opened this issue Jun 14, 2024 · 7 comments
Assignees

Comments

@rich-iannone
Copy link

rich-iannone commented Jun 14, 2024

Submitting Author: Name (@rich-iannone)
All current maintainers: (@rich-iannone, @machow)
Package Name: Great Tables
One-Line Description of Package: Make awesome display tables using Python.
Repository Link: https://github.com/posit-dev/great-tables
Version submitted: v0.13.0
EiC: @Batalex
Editor: @Batalex
Reviewer 1: TBD
Reviewer 2: TBD
Archive: TBD
JOSS DOI: TBD
Version accepted: TBD
Date accepted (month/day/year): TBD


Code of Conduct & Commitment to Maintain Package

Description

The Great Tables package is all about creating tables for the purpose of presentation. You can use
Pandas or Polars DataFrames as inputs, and the Great Tables API allows you to:

  • structure the data using column spanners and row groups, and add header and footer information
  • format the data with a wide range of powerful formatting methods
  • style the table to make it aesthetically pleasing or to highlight important information
  • integrate the table display into notebooks, Quarto documents or web pages, and export the table
    as HTML or a variety of image formats

Scope

  • Please indicate which category or categories.
    Check out our package scope page to learn more about our
    scope. (If you are unsure of which category you fit, we suggest you make a pre-submission inquiry):

    • Data retrieval
    • Data extraction
    • Data processing/munging
    • Data deposition
    • Data validation and testing
    • Data visualization1
    • [] Workflow automation
    • Citation management and bibliometrics
    • Scientific software wrappers
    • Database interoperability

Domain Specific

  • Geospatial
  • Education

Community Partnerships

If your package is associated with an
existing community please check below:

  • For all submissions, explain how and why the package falls under the categories you indicated above. In your explanation, please address the following points (briefly, 1-2 sentences for each):

The package can be seen as a data visualization package, but it is perhaps more in the direction of data presentation/publication (i.e., not datavis in the traditional sense). However, tables are important and they are ubiquitous in all sorts of scientific publications.

  • Who is the target audience and what are scientific applications of this package?

The target audience is anyone who needs to present data in the tabular format. There is a particular focus on science and engineering applications as many of the formatting methods are geared toward this audience (e.g., scientific notation, significant figures, units notation, chemistry notation, etc.).

  • Are there other Python packages that accomplish the same thing? If so, how does yours differ?

There are only a few packages that deal with tabular data presentation. The Pandas styler API is probably the best known of these, but it is limited in its capabilities. A big part of Great Tables is the ability to structure a table to a more traditional table format (one you'd commonly see in journals or reports) instead of interactive tables that are more common in web apps (i.e., displaying hundreds or thousands of rows of data). The formatting capabilities of Great Tables are also much more extensive than Pandas styler or other packages.

  • If you made a pre-submission enquiry, please paste the link to the corresponding issue, forum post, or other discussion, or @tag the editor you contacted:

#184

Technical checks

For details about the pyOpenSci packaging requirements, see our packaging guide. Confirm each of the following by checking the box. This package:

  • does not violate the Terms of Service of any service it interacts with.
  • uses an OSI approved license.
  • contains a README with instructions for installing the development version.
  • includes documentation with examples for all functions.
  • contains a tutorial with examples of its essential functions and uses.
  • has a test suite.
  • has continuous integration setup, such as GitHub Actions CircleCI, and/or others.

Publication Options

JOSS Checks
  • The package has an obvious research application according to JOSS's definition in their submission requirements. Be aware that completing the pyOpenSci review process does not guarantee acceptance to JOSS. Be sure to read their submission requirements (linked above) if you are interested in submitting to JOSS.
  • The package is not a "minor utility" as defined by JOSS's submission requirements: "Minor ‘utility’ packages, including ‘thin’ API clients, are not acceptable." pyOpenSci welcomes these packages under "Data Retrieval", but JOSS has slightly different criteria.
  • The package contains a paper.md matching JOSS's requirements with a high-level description in the package root or in inst/.
  • The package is deposited in a long-term repository with the DOI:

Note: JOSS accepts our review as theirs. You will NOT need to go through another full review. JOSS will only review your paper.md file. Be sure to link to this pyOpenSci issue when a JOSS issue is opened for your package. Also be sure to tell the JOSS editor that this is a pyOpenSci reviewed package once you reach this step.

Are you OK with Reviewers Submitting Issues and/or pull requests to your Repo Directly?

This option will allow reviewers to open smaller issues that can then be linked to PR's rather than submitting a more dense text based review. It will also allow you to demonstrate addressing the issue via PR links.

  • Yes I am OK with reviewers submitting requested changes as issues to my repo. Reviewers will then link to the issues in their submitted review.

Confirm each of the following by checking the box.

  • I have read the author guide.
  • I expect to maintain this package for at least 2 years and can help find a replacement for the maintainer (team) if needed.

Please fill out our survey

P.S. Have feedback/comments about our review process? Leave a comment here

Editor and Review Templates

The editor template can be found here.

The review template can be found here.

Footnotes

  1. Please fill out a pre-submission inquiry before submitting a data visualization package.

@Batalex
Copy link
Contributor

Batalex commented Jun 22, 2024

Editor in Chief checks

Hi there! Thank you for submitting your package for pyOpenSci review. Below are the basic checks that your package needs to pass to begin our review. If some of these are missing, we will ask you to work on them before the review process begins.

Please check our Python packaging guide for more information on the elements
below.

  • Installation The package can be installed from a community repository such as PyPI (preferred), and/or a community channel on conda (e.g. conda-forge, bioconda).
    • The package imports properly into a standard Python environment import package.
  • Fit The package meets criteria for fit and overlap.
  • Documentation The package has sufficient online documentation to allow us to evaluate package function and scope without installing the package. This includes:
    • User-facing documentation that overviews how to install and start using the package.
    • Short tutorials that help a user understand how to use the package and what it can do for them.
    • API documentation (documentation for your code's functions, classes, methods and attributes): this includes clearly written docstrings with variables defined using a standard docstring format.
  • Core GitHub repository Files
    • README The package has a README.md file with clear explanation of what the package does, instructions on how to install it, and a link to development instructions.
    • Contributing File The package has a CONTRIBUTING.md file that details how to install and contribute to the package.
    • Code of Conduct The package has a CODE_OF_CONDUCT.md file.
    • License The package has an OSI approved license.
      NOTE: We prefer that you have development instructions in your documentation too.
  • Issue Submission Documentation All of the information is filled out in the YAML header of the issue (located at the top of the issue template).
  • Automated tests Package has a testing suite and is tested via a Continuous Integration service.
  • Repository The repository link resolves correctly.
  • Package overlap The package doesn't entirely overlap with the functionality of other packages that have already been submitted to pyOpenSci.
  • Archive (JOSS only, may be post-review): The repository DOI resolves correctly.
  • Version (JOSS only, may be post-review): Does the release version given match the GitHub release (v1.0.0)?

  • Initial onboarding survey was filled out
    We appreciate each maintainer of the package filling out this survey individually. 🙌
    Thank you authors in advance for setting aside five to ten minutes to do this. It truly helps our organization. 🙌


Editor comments

This is a really solid submission, and I am super excited for us to contribute to great_tables. I'll get started on finding an editor for this submission.

suggestion: TIL we can store CONTRIBUTING.md in .github. Would you mind adding a section in the README pointing to this file? I knew what I was looking for, but I think the entry barrier for new contributors would be lower if they did not have to open a PR to see the contributing guidelines.

todo: We can get started, but during the review's course, we should add the paper.md file as part of the review.

@cmarmo
Copy link
Member

cmarmo commented Jul 15, 2024

Hi @rich-iannone, thanks again for submitting Great Tables to pyOpenSci!
I'm Chiara and I'm following up as editor in chief for the next three months.
I'm glad to announce that @Batalex is volounteering to serve as editor too for your submission.... Thanks a lot Alex!

@Batalex
Copy link
Contributor

Batalex commented Aug 10, 2024

Hello there @rich-iannone,
I have been looking for reviewers for this submission, but as you might guess, the summer period is slowing down all kinds of interactions. Nonetheless, this submission is still alive and well!

@Batalex
Copy link
Contributor

Batalex commented Oct 26, 2024

Hey @rich-iannone,
Sorry, it took me so long to get back to this review. Let me make it up to you by introducing the two rock stars who volunteered to review great-tables: @glemaitre and @cjbassin.

@glemaitre and @cjbassin, thank you so much or volunteering to review for pyOpenSci! I hope this experience will be as fulfilling as it was for me.

Please fill out our pre-review survey

Before beginning your review, please fill out our pre-review survey. This helps us improve all aspects of our review and better understand our community. No personal data will be shared from this survey - it will only be used in an aggregated format by our Executive Director to improve our processes and programs.

The following resources will help you complete your review:

  1. Here is the reviewers guide. This guide contains all of the steps and information needed to complete your review.
  2. Here is the review template that you will need to fill out and submit
    here as a comment, once your review is complete.

Please get in touch with any questions or concerns! Your review is due: 18th nov.

Reviewers: @glemaitre,@cjbassin
Due date: 2024/11/18

@cjbassin
Copy link

cjbassin commented Oct 31, 2024 via email

@rich-iannone
Copy link
Author

@cjbassin Thanks for noting this! I'd definitely appreciate it if the review were based on v0.13.0 version.

@Batalex
Copy link
Contributor

Batalex commented Nov 1, 2024

Absolutely, I updated the version. Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: under-review
Development

No branches or pull requests

4 participants