-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
THzTools submission #209
Comments
Hello @jsdodge ! Thank you for submitting THzTools to pyOpenSci. |
Hi Chiara, Thanks for the update on the timeline. Do you have any suggestions for ways that we can continue development without disrupting the review? Would it be ok, for example, to continue developing on the |
I'm starting the editorial checks right now: I can perform them on the main branch if you prefer, once we agree on a version to be submitted you can tag the last modifications and we can update the description of the issue. Would that be ok for you? |
Editor in Chief checksHi @jsdodge ! Thank you again for submitting your package for pyOpenSci review. Please check our Python packaging guide for more information on the elements
Editor commentsTHzTools is in excellent shape, congratulations!
I realize my answer was a bit out of scope... sorry for that. Indeed, I believe it is a good idea to continue the development in a separate branch during review: however, reviewers might ask for modifications too and everything would in principle end in a new version accepted at the end of the review process. Please just clarify with reviewers in which branch you are addressing their comments, we had some misunderstanding in the past. |
Hi Chiara, Thanks! We can add installation instructions to the Regarding the |
Technically the review is not started yet: once done with the changes we can edit the issue description.
Some general information would be enough in the
Your solution is fine with our standards: if you prefer to have the code of conduct in the documentation then you can use the same approach suggested for the |
I just released THzTools v0.5.1 with the changes that you requested. I've also updated the version number in the submission documentation. |
Thank you @jsdodge ! Time for me to look for an editor! |
Hi @cmarmo, I have just updated the submission with the latest release, v0.5.2. Could you please update me on the editor search? |
Thank you @jsdodge for the follow-up
I'm sorry to say that I am still looking... I guess the end of summer plus the beginning of the academic year are not making things easier.... thanks for your patience! |
Submitting Author: Name (@jsdodge)
All current maintainers: (@jsdodge)
Package Name: THzTools
Data analysis software tools for terahertz time-domain spectroscopy (THz-TDS)
Repository Link: https://github.com/dodge-research-group/thztools
Version submitted: 0.5.2
EiC: @cmarmo
Editor: TBD
Reviewer 1: TBD
Reviewer 2: TBD
Archive: TBD
JOSS DOI: TBD
Version accepted: TBD
Date accepted (month/day/year): TBD
Code of Conduct & Commitment to Maintain Package
Description
THzTools provides tools to simplify and improve procedures for data analysis in terahertz time-domain spectroscopy (THz-TDS). Some of the methods included in the package were described previously in the paper at this link. As the name suggests, terahertz time-domain spectroscopy involves measurements of terahertz-frequency electromagnetic waveforms that are are acquired as a function of time. A variety of methods exist to transform these measurements into functions of frequency, but the standard procedures have several pitfalls. THzTools provides software tools that make it easier for researchers to use the best available methods for analyzing their data.
Scope
Please indicate which category or categories.
Check out our package scope page to learn more about our
scope. (If you are unsure of which category you fit, we suggest you make a pre-submission inquiry):
Domain Specific
Community Partnerships
If your package is associated with an
existing community please check below:
For all submissions, explain how and why the package falls under the categories you indicated above. In your explanation, please address the following points (briefly, 1-2 sentences for each):
Who is the target audience and what are scientific applications of this package?
The target audience is researchers working with THz-TDS, although the procedures may be useful in other areas that use time-domain measurement systems. The package is designed for characterizing the time-domain noise performance of THz-TDS measurement systems and for analyzing the results from these systems in the frequency domain.
Are there other Python packages that accomplish the same thing? If so, how does yours differ?
The Fit-TDS package provides a graphical user interface that simplifies THz-TDS data analysis with standard analysis methods. THzTools focuses on lower-level statistical procedures, and implements algorithms that are not available in Fit-TDS.
If you made a pre-submission enquiry, please paste the link to the corresponding issue, forum post, or other discussion, or
@tag
the editor you contacted: @NickleDaveTechnical checks
For details about the pyOpenSci packaging requirements, see our packaging guide. Confirm each of the following by checking the box. This package:
Publication Options
JOSS Checks
paper.md
matching JOSS's requirements with a high-level description in the package root or ininst/
.Note: JOSS accepts our review as theirs. You will NOT need to go through another full review. JOSS will only review your paper.md file. Be sure to link to this pyOpenSci issue when a JOSS issue is opened for your package. Also be sure to tell the JOSS editor that this is a pyOpenSci reviewed package once you reach this step.
Are you OK with Reviewers Submitting Issues and/or pull requests to your Repo Directly?
This option will allow reviewers to open smaller issues that can then be linked to PR's rather than submitting a more dense text based review. It will also allow you to demonstrate addressing the issue via PR links.
Confirm each of the following by checking the box.
Please fill out our survey
submission and improve our peer review process. We will also ask our reviewers
and editors to fill this out.
P.S. Have feedback/comments about our review process? Leave a comment here
Editor and Review Templates
The editor template can be found here.
The review template can be found here.
Footnotes
Please fill out a pre-submission inquiry before submitting a data visualization package. ↩
The text was updated successfully, but these errors were encountered: