Rename RectangularROI views

Author: gselzer

src/ndv/views/_pygfx/_array_canvas.py

@@ -110,7 +110,7 @@ def get_cursor(self, mme: MouseMoveEvent) -> CursorType | None:
         return None
 
 
-class PyGFXBoundingBox(RectangularROI):
+class PyGFXRectangularROI(RectangularROI):
     def __init__(
         self,
         render: Callable,
@@ -407,8 +407,8 @@ def __init__(self, viewer_model: ArrayViewerModel) -> None:
 
         self._elements = WeakKeyDictionary[pygfx.WorldObject, CanvasElement]()
         self._selection: CanvasElement | None = None
-        # TODO: Weak Reference?
-        self._last_roi_created: ReferenceType[PyGFXBoundingBox] | None = None
+        # Maintain a weak reference to the last ROI created.
+        self._last_roi_created: ReferenceType[PyGFXRectangularROI] | None = None
 
     def frontend_widget(self) -> Any:
         return self._canvas
@@ -504,9 +504,9 @@ def add_volume(self, data: np.ndarray | None = None) -> PyGFXImageHandle:
         self._elements[vol] = handle
         return handle
 
-    def add_bounding_box(self) -> PyGFXBoundingBox:
+    def add_bounding_box(self) -> PyGFXRectangularROI:
         """Add a new Rectangular ROI node to the scene."""
-        roi = PyGFXBoundingBox(
+        roi = PyGFXRectangularROI(
             render=self.refresh,
             canvas_to_world=self.canvas_to_world,
             parent=self._scene,

src/ndv/views/_vispy/_array_canvas.py

@@ -116,7 +116,7 @@ def get_cursor(self, mme: MouseMoveEvent) -> CursorType | None:
         return None
 
 
-class VispyBoundingBox(RectangularROI):
+class VispyRectangularROI(RectangularROI):
     def __init__(self, parent: Any) -> None:
         self._selected = False
         self._move_mode: ROIMoveMode | None = None
@@ -307,8 +307,8 @@ def __init__(self, viewer_model: ArrayViewerModel) -> None:
 
         self._elements: WeakKeyDictionary = WeakKeyDictionary()
         self._selection: CanvasElement | None = None
-        # TODO: Weak Reference?
-        self._last_roi_created: ReferenceType[VispyBoundingBox] | None = None
+        # Maintain weak reference to last ROI created
+        self._last_roi_created: ReferenceType[VispyRectangularROI] | None = None
 
     @property
     def _camera(self) -> vispy.scene.cameras.BaseCamera:
@@ -389,9 +389,9 @@ def add_volume(self, data: np.ndarray | None = None) -> VispyImageHandle:
             self.set_range()
         return handle
 
-    def add_bounding_box(self) -> VispyBoundingBox:
+    def add_bounding_box(self) -> VispyRectangularROI:
         """Add a new Rectangular ROI node to the scene."""
-        roi = VispyBoundingBox(parent=self._view.scene)
+        roi = VispyRectangularROI(parent=self._view.scene)
         roi.set_visible(False)
         self._elements[roi._handles] = roi
         self._elements[roi._rect] = roi
@@ -423,7 +423,7 @@ def set_range(
                 _y[1] = max(_y[1], shape[1])
                 if len(shape) > 2:
                     _z[1] = max(_z[1], shape[2])
-            elif isinstance(handle, VispyBoundingBox):
+            elif isinstance(handle, VispyRectangularROI):
                 for v in handle.vertices:
                     _x[0] = min(_x[0], v[0])
                     _x[1] = max(_x[1], v[0])