Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove benchmarks/work_precision_sets and related files (dead code) #4766

Open
Saransh-cpp opened this issue Jan 16, 2025 · 0 comments · May be fixed by #4771
Open

Remove benchmarks/work_precision_sets and related files (dead code) #4766

Saransh-cpp opened this issue Jan 16, 2025 · 0 comments · May be fixed by #4771
Labels
difficulty: easy A good issue for someone new. Can be done in a few hours priority: low No existing plans to resolve

Comments

@Saransh-cpp
Copy link
Member

This is supposed to be in the validation repository (which is not functioning well at the moment as it has gone stale). The files here are dead code, and I am pretty sure they do not run in any CI.

https://github.com/pybamm-team/PyBaMM/tree/develop/benchmarks/work_precision_sets
@Saransh-cpp Saransh-cpp added difficulty: easy A good issue for someone new. Can be done in a few hours priority: low No existing plans to resolve labels Jan 16, 2025
@vidipsingh vidipsingh linked a pull request Jan 16, 2025 that will close this issue
Open
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty: easy A good issue for someone new. Can be done in a few hours priority: low No existing plans to resolve
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Clean up benchmarks by removing dead code from work_precision_sets vidipsingh/PyBaMM
1 participant
@Saransh-cpp