Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Fix Integration tests post #304 #320

Closed
BradyPlanden opened this issue May 10, 2024 · 2 comments · Fixed by #321
Closed

[Bug]: Fix Integration tests post #304 #320

BradyPlanden opened this issue May 10, 2024 · 2 comments · Fixed by #321
Assignees
Labels
bug Something isn't working

Comments

@BradyPlanden
Copy link
Member

BradyPlanden commented May 10, 2024

Python Version

N/A

Describe the bug

#304 has reduced the test suite completion time, but has resulted in a higher failure rate of the integration tests. A fix is available in #319 and will be duplicated into this branch to expedite the fix.

Steps to reproduce the behaviour

See: https://github.com/pybop-team/PyBOP/actions/runs/9019436453/job/24782313287

Relevant log output

No response

@BradyPlanden BradyPlanden added the bug Something isn't working label May 10, 2024
@BradyPlanden BradyPlanden self-assigned this May 10, 2024
@BradyPlanden BradyPlanden mentioned this issue May 10, 2024
15 tasks
@BradyPlanden BradyPlanden linked a pull request May 10, 2024 that will close this issue
15 tasks
@NicolaCourtier
Copy link
Member

I also saw this when I merged develop into #236, changing the scale in line 15 in tests/integration/test_parameterisations.py seems to help. I reduced it from 0.05 to 0.03 in that PR.

@BradyPlanden
Copy link
Member Author

Thanks @NicolaCourtier. I've opened a PR for this fix now. I was able to fix this issue without changing the range of potential parameter values. This was achieveable without extending the synthetic prediction, but the extension should help with identifiability of the fitting parameters in this case.

It should be ready for review soon, I want to run the scheduled workflow on the branch for confirmation. On initial testing, this change appears to allow for tighter assertions on the parameterisations test, which would be great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants