From 53b063802a46083b1869c07029014477f432c0ca Mon Sep 17 00:00:00 2001
From: iknowright <changchaishi@gmail.com>
Date: Sun, 21 Apr 2024 12:39:02 +0800
Subject: [PATCH] fix(category): fix category filtering not working when order
 by other attributes on review table

---
 .../reviews/_includes/proposal_table.html        | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/src/templates/default/reviews/_includes/proposal_table.html b/src/templates/default/reviews/_includes/proposal_table.html
index fb4a65a2f..a7f132163 100644
--- a/src/templates/default/reviews/_includes/proposal_table.html
+++ b/src/templates/default/reviews/_includes/proposal_table.html
@@ -4,9 +4,9 @@
 	<tr>
 		{% if not verdict %}
 			<th width="1%">
-				<a {% if ordering == 'review__count' %}class="active asc" href="?order=-count&category={{ category }}"
-					 {% elif ordering == '-review__count' %}class="active desc" href="?order=count&category={{ category }}"
-					 {% else %}href="?order=count&category={{ category }}"{% endif %}>
+				<a {% if ordering == 'review__count' %}class="active asc" href="?order=-count&category={{ category|default:'' }}"
+					 {% elif ordering == '-review__count' %}class="active desc" href="?order=count&category={{ category|default:'' }}"
+					 {% else %}href="?order=count&category={{ category|default:'' }}"{% endif %}>
 					{% trans 'Reviewed' %}
 					<i class="fa fa-sort fa-lg"></i>
 					<i class="fa fa-sort-asc fa-lg"></i>
@@ -15,8 +15,8 @@
 			</th>
 		{% endif %}
 		<th class="proposal-title">
-			<a {% if ordering == 'title' %}class="active asc" href="?order=-title&category={{ category }}"
-				 {% elif ordering == '-title' %}class="active desc" href="?order=title&category={{ category }}"{% else %}href="?order=title&category={{ category }}"{% endif %}>
+			<a {% if ordering == 'title' %}class="active asc" href="?order=-title&category={{ category|default:'' }}"
+				 {% elif ordering == '-title' %}class="active desc" href="?order=title&category={{ category|default:'' }}"{% else %}href="?order=title&category={{ category|default:'' }}"{% endif %}>
 				{% trans 'Title' %}
 				<i class="fa fa-sort fa-lg"></i>
 				<i class="fa fa-sort-asc fa-lg"></i>
@@ -24,9 +24,9 @@
 			</a>
 		</th>
 		<th width="1%" class="hidden-md hidden-sm hidden-xs">
-			<a {% if ordering == 'language' %}class="active asc" href="?order=-lang&category={{ category }}"
-				 {% elif ordering == '-language' %}class="active desc" href="?order=lang&category={{ category }}"
-				 {% else %}href="?order=lang&category={{ category }}"{% endif %}>
+			<a {% if ordering == 'language' %}class="active asc" href="?order=-lang&category={{ category|default:'' }}"
+				 {% elif ordering == '-language' %}class="active desc" href="?order=lang&category={{ category|default:'' }}"
+				 {% else %}href="?order=lang&category={{ category|default:'' }}"{% endif %}>
 				{% trans 'Lang' %}
 				<i class="fa fa-sort fa-lg"></i>
 				<i class="fa fa-sort-asc fa-lg"></i>