Can cache properties with mangled names #167
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AWhetter
commented
Jul 2, 2019
| self.__doc__ = getattr(func, "__doc__") | ||
| self.func = func | ||
| def __init__(self, func, name=None): | ||
| if not callable(func): |
There was a problem hiding this comment.
I wasn't sure if this was the right thing to do here. I did consider making func optional so that users have to specify arguments with keywords. Ultimately I decided to go with the pattern that already existed in the other classes.
AWhetter
commented
Jul 2, 2019
| @@ -77,31 +122,39 @@ def test_cached_property(self): | |||
| self.assert_control(check, 2) | |||
|
|
|||
| # The cached version demonstrates how nothing is added after the first | |||
| self.assert_cached(check, 1) | |||
| self.assert_cached(check, 1) | |||
| for cached_attr, total_attr in self.cached_attrs: | |||
There was a problem hiding this comment.
I was unsure if this was the right thing to do as well. It makes the tests a bit more complicated. I considered making a separate TestCase classes for each type of attribute, but considering that the duplicate tests would be testing pretty much the same thing, it made sense to me to test all types of attribute in a single test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #102