From 1af1b49d6afa4be61e8c32a0510e97c85301e747 Mon Sep 17 00:00:00 2001 From: Adrian Garcia Badaracco <1755071+adriangb@users.noreply.github.com> Date: Fri, 15 Nov 2024 11:51:24 -0600 Subject: [PATCH] fix docs of register_table to match implementation I'm not sure that changing the implementation is possible at this point. We could call deregister_table but I fear that's not atomic. So we'd have to change the implementation of SchemaProvider, a breaking change. --- datafusion/core/src/execution/context/mod.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/datafusion/core/src/execution/context/mod.rs b/datafusion/core/src/execution/context/mod.rs index 621b214818e9..205e308b7c84 100644 --- a/datafusion/core/src/execution/context/mod.rs +++ b/datafusion/core/src/execution/context/mod.rs @@ -1312,8 +1312,8 @@ impl SessionContext { /// Registers a [`TableProvider`] as a table that can be /// referenced from SQL statements executed against this context. /// - /// Returns the [`TableProvider`] previously registered for this - /// reference, if any + /// If a table of the same name was already registered, returns "Table + /// already exists" error. pub fn register_table( &self, table_ref: impl Into,