Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Projection (Ships, fits, and modules) #17

Open
DarkFenX opened this issue Oct 18, 2016 · 0 comments
Open

Projection (Ships, fits, and modules) #17

DarkFenX opened this issue Oct 18, 2016 · 0 comments

Comments

@DarkFenX
Copy link
Member

Posted by @Ebag333

Currently doesn't seem to be any way to project something onto a fit.

We need to be able to project entire fits. We may also want to project single modules. Pyfa does this currently, but it's often not particularly useful as it just uses base stats which are often far off from the actual stats (especially when bonused hulls are in play).

We could do something like:

fit.project.add(Fit(2446, state=State.hostile))
fit.project.add(Fit(3447, state=State.friendly))
fit.project.add(Module(5443, state=State.Active))

We need to support multiple states.

For modules (if we want to support them, which again I think is of limited use) we just need a state of:

  • Online
  • Offline

For fits we need four states:

  • Offline
  • All
  • Friendly
  • Hostile

The reason for the extra states is that it is currently painful to project fits when they have mixed modules in Pyfa. If my command ship alt has links and neuts, and I project it onto my Vengeance, then my Vengeance will show that I am getting neuted when that will never be the case.

This will become especially bad with the way that CCP is planning on command bursts, where you might have 10+ ships applying command bursts. By being able to sets a projecting ship to friendly, you only allow the beneficial modules to apply (bursts, logi, remote sebo, etc).

Conversely, if you set it to hostile, you can filter out any friendly modules.

Alternatively, we could separate out online/offline from friendly/hostile/all. In current Pyfa we already had the online/offline code, so @blitzmann and I had discussed simply adding a new column for friendly/hostile/all so we didn't have to touch online/offline.

Not sure which is easier in Eos, but either solution would work.

Ebag333 added a commit to Ebag333/eos that referenced this issue Oct 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant