-
Notifications
You must be signed in to change notification settings - Fork 62
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
norm
now uses metric.square_root_of_expr
again, with fixes
1. It now accepts a hint that the expr is nonnegative etc, avoiding unnecessary `abs` calls 2. It had a bug that incorrectly assumed that the sqrt of even product is the product of powers divided by 2 is nonnegative, thus lacking an `abs` call. Passing previously failing tests locally without modifying any notebooks: ``` pytest test/test_mv.py -vv pytest --nbval examples/ipython/test_gsg_undual_etc.ipynb --nbval-current-env --nbval-sanitize-with test/.nbval_sanitize.cfg -vv ```
- Loading branch information
Showing
2 changed files
with
19 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters