Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] pivot_longer test cases failed on pandas latest (1.4.x) passed on 1.3.x #1154

Closed
Zeroto521 opened this issue Aug 20, 2022 · 2 comments · Fixed by #1155
Closed

[BUG] pivot_longer test cases failed on pandas latest (1.4.x) passed on 1.3.x #1154

Zeroto521 opened this issue Aug 20, 2022 · 2 comments · Fixed by #1155
Labels
bug Something isn't working infrastructure Infrastructure-related issues testing Issues related to testing

Comments

@Zeroto521
Copy link
Member

I found why #1143 failed on pivot_longer, encode_categorical, and _select_column test cases
The core reason is the version compatibility.
Our current test environment only tests one main pandas version 1.3.x. But the latest pandas version is 1.4.x.

- pandas=1.3.5

There pivot_longer method test cases failed on pandas latest version (1.4.x), but passed on 1.3.x.

Call for helping @samukweku, (I do use less about pivot_longer accessor, so I can't handle these problems).

  • tests/functions/test_pivot_longer.py::test_names_pattern_str
  • tests/functions/test_pivot_longer.py::test_names_sep
  • tests/functions/test_pivot_longer.py::test_names_transform_numeric
@Zeroto521 Zeroto521 added bug Something isn't working testing Issues related to testing infrastructure Infrastructure-related issues labels Aug 20, 2022
@samukweku
Copy link
Collaborator

@Zeroto521 Do you have any idea about the test_documentation_build.py failure?

@Zeroto521
Copy link
Member Author

Mkdocs and its related packages are not in environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working infrastructure Infrastructure-related issues testing Issues related to testing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants