WIP - move to pyproject.toml #1336
Draft
+46
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
draft work - needs actual experts @loganthomas @ericmjl 😁 |
ericmjl
reviewed
Feb 13, 2024
.github/workflows/auto-release.yml
Outdated
| python3 -m | ||
| pip install | ||
| build | ||
| --user |
There was a problem hiding this comment.
TIL something new about the ecosystem today!
Does this have to be multi-line, btw? Just curious, it looks more like a single-line bash command.
There was a problem hiding this comment.
i just did a copy and paste, but it's yaml, so it should just fit into one line
ericmjl
reviewed
Feb 13, 2024
ericmjl
reviewed
Feb 13, 2024
| "pandas_flavor", | ||
| "multiple_dispatch", | ||
| "scipy" | ||
| ] |
There was a problem hiding this comment.
Wow! Is the dependency list really this small? I suspect it might be longer, though.
There was a problem hiding this comment.
i pulled it from `.requirements/base.in', based on information in setup.py
ericmjl
reviewed
Feb 13, 2024
Co-authored-by: Eric Ma <[email protected]>
Co-authored-by: Eric Ma <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Please describe the changes proposed in the pull request:
**This PR resolves #1295 **
PR Checklist
Please ensure that you have done the following:
<your_username>:dev, but rather from<your_username>:<feature-branch_name>.AUTHORS.md.CHANGELOG.mdunder the latest version header (i.e. the one that is "on deck") describing the contribution.Automatic checks
There will be automatic checks run on the PR. These include:
Relevant Reviewers
Please tag maintainers to review.