Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardization of getllm-output column-names #100

Open
JoschD opened this issue Mar 13, 2018 · 1 comment
Open

Standardization of getllm-output column-names #100

JoschD opened this issue Mar 13, 2018 · 1 comment

Comments

@JoschD
Copy link
Member

JoschD commented Mar 13, 2018

If you see some, that don't make sense, add to this issue. One day we can change them all:

everywhere:
MDL, STD etc. either in front or after the name.
(as of now, MDL is after, everything else in front... most of the time)

getcouple.out:
FWSTD1 -> STDF1001W
FWSTD2 -> STDF1010W

Everything in ndiff:
A massacre of
upper-case vs. lower-case,
_m vs. MDL vs. _model,
re vs. r vs. R,
im vs. i vs. I,
e vs. ERR,

@awegsche
Copy link
Contributor

awegsche commented Mar 14, 2018

I am very happy to contribute to this list. Unfortunately this would create huge changes to the GUI code without any real gain.

I already brought up this issue for getbeta*.out, getampbeta*.out, getphase*.out in order to better reflect actual values (statistical / systematic errors can't be distinguished in the analytical N-BPM method, column names weren't consistent for 3-BPM and N-BPM method).

My suggestions to this issue:

  • remove completely statistical and systematical error columns in getbeta*.out. N-BPM doesn't distinguish between them and 3-BPM only includes statistical errors. So we could just keep ERRBET
  • change PHASE in getphase*.out to DELTAMU or DMU since it is the phase advance between the two elements and not the phase advance to the origin.
  • in getphase*.out, clear up NAME, NAME2 but S, S1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants