Align autogenerated dimension names when dims and default_dims are provided
#2395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2395 +/- ##
=======================================
Coverage 86.81% 86.81%
=======================================
Files 124 124
Lines 12883 12883
=======================================
Hits 11184 11184
Misses 1699 1699 ☔ View full report in Codecov by Sentry. |
lucianopaz
force-pushed
the
default_dims
branch
from
0b372a8
to
ea4f2b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR closes pymc-devs/pymc#7572 and also #2397
There was a problem with auto generated dimension names for
sample_posterior_predictive(but not forsample_prior_predictive). The only difference was that one code branch providedsample_dimsand the other didn't, which resulted in having a list ofdimsingenerate_dims_coords. This led to incorrect imputation of the dimension name.Checklist
📚 Documentation preview 📚: https://arviz--2395.org.readthedocs.build/en/2395/