Double check correctness of causal impact calculation in scikit-learn flavour of `DifferenceInDifferences`

[drbenvincent]

At the moment we have a TODO comment which needs some attention

# This is the coefficient on the interaction term
# TODO: THIS IS NOT YET CORRECT ?????
self.causal_impact = (
    self.y_pred_treatment[1] - self.y_pred_counterfactual[0]
)[0]

From memory, this is not wrong, but achieved the right effect in a different manner to the pymc flavour of difference in differences.

Either way, we need to double check and resolve.

[roesta07]

Hi @drbenvincent I recently worked on a DID project using Pymc. I would be happy to contribute if possible. Could you confirm on this bug?
Did you mean to directly reference the interaction parameter(causal_estimate) from the sklearn model's estimate as we did it for pymc model?